Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/content_settings/core/common/BUILD.gn

Issue 410993002: Componentize content_settings_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with trunk Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/content_settings.gypi ('K') | « components/content_settings/OWNERS ('k') | components/content_settings/core/common/content_settings_types.h » ('j') | components/content_settings/core/common/content_settings_types.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/common/BUILD.gn
diff --git a/components/history/core/common/BUILD.gn b/components/content_settings/core/common/BUILD.gn
similarity index 72%
copy from components/history/core/common/BUILD.gn
copy to components/content_settings/core/common/BUILD.gn
index 7a493141978ebc86786ede32720f563e8a537d74..bba0732886dbdffe9a6fce019daea6598761a708 100644
--- a/components/history/core/common/BUILD.gn
+++ b/components/content_settings/core/common/BUILD.gn
@@ -4,11 +4,7 @@
static_library("common") {
jochen (gone - plz use gerrit) 2014/07/24 09:57:40 should be source_set
vasilii 2014/07/24 10:52:25 Done.
sources = [
- "thumbnail_score.cc",
- "thumbnail_score.h",
- ]
-
- deps = [
- "//base",
+ "content_settings_types.cc",
jochen (gone - plz use gerrit) 2014/07/24 09:57:40 not required on gn
vasilii 2014/07/24 10:52:25 Done.
+ "content_settings_types.h",
]
}
« components/content_settings.gypi ('K') | « components/content_settings/OWNERS ('k') | components/content_settings/core/common/content_settings_types.h » ('j') | components/content_settings/core/common/content_settings_types.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698