components/content_settings/core/common/BUILD.gn - Issue 410993002: Componentize content_settings_types.h

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/content_settings/core/common/BUILD.gn

Issue 410993002: Componentize content_settings_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with trunk Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 static_library("common") {	5 static_library("common") {
	jochen (gone - plz use gerrit) 2014/07/24 09:57:40 should be source_set should be source_set vasilii 2014/07/24 10:52:25 Done. Show quoted text On 2014/07/24 09:57:40, jochen wrote: > should be source_set Done.
6 sources = [	6 sources = [

7 "thumbnail_score.cc",	7 "content_settings_types.cc",
	jochen (gone - plz use gerrit) 2014/07/24 09:57:40 not required on gn not required on gn vasilii 2014/07/24 10:52:25 Done. Show quoted text On 2014/07/24 09:57:40, jochen wrote: > not required on gn Done.
8 "thumbnail_score.h",	8 "content_settings_types.h",

9 ]

10

11 deps = [

12 "//base",

13 ]	9 ]

14 }	10 }

OLD	NEW