chrome/common/service_process_util_unittest.cc - Issue 410843003: Disable all the tests that are flaking more than 5% on Windows builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/service_process_util_unittest.cc

Issue 410843003: Disable all the tests that are flaking more than 5% on Windows builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc ('k') | chrome/installer/util/work_item_list_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/service_process_util_unittest.cc

diff --git a/chrome/common/service_process_util_unittest.cc b/chrome/common/service_process_util_unittest.cc

index f73a6536b1593b892628b29a3fe1b86709618679..5f97d264638d4a70059a45e0a29ed3a613bc6ee1 100644

--- a/chrome/common/service_process_util_unittest.cc

+++ b/chrome/common/service_process_util_unittest.cc

@@ -108,7 +108,8 @@ TEST_F(ServiceProcessStateTest, Singleton) {

LaunchAndWait("ServiceProcessStateTestSingleton");

}

-TEST_F(ServiceProcessStateTest, ReadyState) {

+// http://crbug.com/396390

+TEST_F(ServiceProcessStateTest, DISABLED_ReadyState) {

ASSERT_FALSE(CheckServiceProcessReady());

ServiceProcessState state;

ASSERT_TRUE(state.Initialize());

@@ -167,7 +168,8 @@ TEST_F(ServiceProcessStateTest, AutoRun) {

#endif // defined(OS_WIN)

}

-TEST_F(ServiceProcessStateTest, SharedMem) {

+// http://crbug.com/396390

+TEST_F(ServiceProcessStateTest, DISABLED_SharedMem) {

std::string version;

base::ProcessId pid;

#if defined(OS_WIN)