chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc - Issue 410843003: Disable all the tests that are flaking more than 5% on Windows builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

Issue 410843003: Disable all the tests that are flaking more than 5% on Windows builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc ('k') | chrome/common/service_process_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

diff --git a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

index 8809d62b11d3036c9521e20f2e3a8e6409c3e74e..6a5dc67acca046b36a8ab0181f0e02fdfb92aa85 100644

--- a/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

+++ b/chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc

@@ -169,7 +169,8 @@ class ProfileSigninConfirmationHelperTest : public testing::Test {

#endif

};

-TEST_F(ProfileSigninConfirmationHelperTest, DoNotPromptForNewProfile) {

+// http://crbug.com/393149

+TEST_F(ProfileSigninConfirmationHelperTest, DISABLED_DoNotPromptForNewProfile) {

// Profile is new and there's no profile data.

EXPECT_FALSE(

GetCallbackResult(

@@ -217,7 +218,9 @@ TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_Extensions) {

base::Bind(&ui::CheckShouldPromptForNewProfile, profile_.get())));

}

-TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_History) {

+// http://crbug.com/393149

+TEST_F(ProfileSigninConfirmationHelperTest,

+ DISABLED_PromptForNewProfile_History) {

HistoryService* history = HistoryServiceFactory::GetForProfile(

profile_.get(),

Profile::EXPLICIT_ACCESS);

@@ -240,7 +243,9 @@ TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_History) {

profile_.get())));

}

-TEST_F(ProfileSigninConfirmationHelperTest, PromptForNewProfile_TypedURLs) {

+// http://crbug.com/393149

+TEST_F(ProfileSigninConfirmationHelperTest,

+ DISABLED_PromptForNewProfile_TypedURLs) {

HistoryService* history = HistoryServiceFactory::GetForProfile(

profile_.get(),

Profile::EXPLICIT_ACCESS);