Disable all the tests that are flaking more than 5% on Windows builders.

Disable all the tests that are flaking more than 5% on Windows builders.

Data from http://chromium-build-logs.appspot.com/flakiness_dashboard?master=chromium.win.

BUG=386891, 387124, 396373, 396384, 396386, 396387, 396388, 396390, 396392, 387124, 396393, 396395, 396399, 396402, 396403, 396404, 396405, 393149, 396409, 95557, 396413, 396414, 375894
R=viettrungluu@chromium.org
TBR=brettw, rvargas, sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284977

[viettrungluu, 2014-07-23 16:18:52]

https://codereview.chromium.org/410843003/diff/40001/content/browser/plugin_b...
File content/browser/plugin_browsertest.cc (right):

https://codereview.chromium.org/410843003/diff/40001/content/browser/plugin_b...
content/browser/plugin_browsertest.cc:357: #if !defined(OS_WIN) //
http://crbug.com/396373
Probably you should just define this as MAYBE_PrivateEnabled and define that to
be DISABLED_... on Windows (and get rid of the use of Justin's confusingly-named
MAYBE macro).

https://codereview.chromium.org/410843003/diff/40001/content/browser/plugin_b...
content/browser/plugin_browsertest.cc:367: // These used to run on Windows:
http://crbug.com/396373
"

[jam, 2014-07-23 16:30:10]

https://codereview.chromium.org/410843003/diff/40001/content/browser/plugin_b...
File content/browser/plugin_browsertest.cc (right):

https://codereview.chromium.org/410843003/diff/40001/content/browser/plugin_b...
content/browser/plugin_browsertest.cc:357: #if !defined(OS_WIN) //
http://crbug.com/396373
On 2014/07/23 16:18:52, viettrungluu wrote:
> Probably you should just define this as MAYBE_PrivateEnabled and define that
to
> be DISABLED_... on Windows (and get rid of the use of Justin's
confusingly-named
> MAYBE macro).

the complexity is because of that x64 macro. if i make it MAYBE_, then if
someone fixes it on windows they might not use the MAYBE() and then it'll fail
on x64. so that's why i disabled it this way.

[viettrungluu, 2014-07-23 16:38:50]

https://codereview.chromium.org/410843003/diff/40001/content/browser/plugin_b...
File content/browser/plugin_browsertest.cc (right):

https://codereview.chromium.org/410843003/diff/40001/content/browser/plugin_b...
content/browser/plugin_browsertest.cc:357: #if !defined(OS_WIN) //
http://crbug.com/396373
On 2014/07/23 16:30:10, jam wrote:
> On 2014/07/23 16:18:52, viettrungluu wrote:
> > Probably you should just define this as MAYBE_PrivateEnabled and define that
> to
> > be DISABLED_... on Windows (and get rid of the use of Justin's
> confusingly-named
> > MAYBE macro).
> 
> the complexity is because of that x64 macro. if i make it MAYBE_, then if
> someone fixes it on windows they might not use the MAYBE() and then it'll fail
> on x64. so that's why i disabled it this way.

Right, but the problem with just ifdef-ing them out is that they won't even be
compiled anymore (so compilation may be broken) and they won't show up in lists
of disabled tests.

I figure than turning them to standard MAYBE_.../DISABLED_... is okay, because
anyone who tries to reenable them would then immediately notice that it's broken
on Win x64. (Or maybe stuff will have been implemented on x64 by then.)

[viettrungluu, 2014-07-23 17:08:37]

lgtm