Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 410743005: Ensure that llvm-mc parses unit tests in x86-32 mode. (Closed)

Created:
6 years, 5 months ago by wala
Modified:
6 years, 5 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Add -arch=x86 and -filetype=obj to all RUN lines involving llvm-mc. This fixes the failing validation of callindirect.pnacl.ll. The following tests fail to validate (some due to the addition of -filetype=obj): * convert.ll * globalinit.pnacl.ll * mangle.ll * nacl-atomic-fence-all.ll * shift.ll BUG=none R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d9ea7ad

Patch Set 1 #

Patch Set 2 : Add -filetype=obj #

Patch Set 3 : Remove redundant test line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -45 lines) Patch
M tests_lit/llvm2ice_tests/64bit.pnacl.ll View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/alloc.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/bitcast.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/callindirect.pnacl.ll View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/cmp-opt.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/convert.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/div_legalization.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/fpconst.pnacl.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/globalinit.pnacl.ll View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/mangle.ll View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-fence-all.ll View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-intrinsics.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/select-opt.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/shift.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/undef.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/unreachable.ll View 1 1 chunk +2 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/vector-arg.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-arith.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-bitcast.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-ops.ll View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wala
6 years, 5 months ago (2014-07-22 23:48:27 UTC) #1
Jim Stichnoth
LGTM. If you want to be absolutely true to the way llvm-mc is run, also ...
6 years, 5 months ago (2014-07-23 00:07:25 UTC) #2
wala
On 2014/07/23 00:07:25, stichnot wrote: > LGTM. > > If you want to be absolutely ...
6 years, 5 months ago (2014-07-23 01:22:01 UTC) #3
wala
6 years, 5 months ago (2014-07-23 01:26:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as rd9ea7ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698