Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 410743002: [refactor] Replace custom utility function with base's "vector_as_array()" (Closed)

Created:
6 years, 5 months ago by eroman
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[refactor] Replace custom utility function with base's "vector_as_array()" BUG=395823 R=rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284984

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : build fix #

Patch Set 4 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -58 lines) Patch
M content/child/webcrypto/nss/aes_cbc_nss.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/webcrypto/nss/aes_gcm_nss.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/webcrypto/nss/hmac_nss.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/child/webcrypto/nss/rsa_oaep_nss.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/child/webcrypto/nss/sha_nss.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/webcrypto/openssl/aes_cbc_openssl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/child/webcrypto/openssl/aes_gcm_openssl.cc View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M content/child/webcrypto/openssl/hmac_openssl.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/sha_openssl.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 3 11 chunks +19 lines, -20 lines 0 comments Download
M content/child/webcrypto/webcrypto_impl.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 3 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
eroman
6 years, 5 months ago (2014-07-22 19:45:09 UTC) #1
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-22 21:08:29 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-22 21:10:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/410743002/1
6 years, 5 months ago (2014-07-22 21:11:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 21:41:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 21:42:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/172644) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/161674) ios_rel_device_ninja ...
6 years, 5 months ago (2014-07-22 21:42:59 UTC) #7
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-22 21:48:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/410743002/20001
6 years, 5 months ago (2014-07-22 21:49:59 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 00:43:15 UTC) #10
eroman
The CQ bit was unchecked by eroman@chromium.org
6 years, 5 months ago (2014-07-23 00:44:06 UTC) #11
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-23 00:48:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/410743002/40001
6 years, 5 months ago (2014-07-23 00:48:45 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 05:02:36 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 06:10:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31250)
6 years, 5 months ago (2014-07-23 06:10:27 UTC) #16
eroman
6 years, 5 months ago (2014-07-23 17:48:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 manually as r284984 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698