content/child/webcrypto/nss/aes_gcm_nss.cc - Issue 410743002: [refactor] Replace custom utility function with base's "vector_as_array()"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/nss/aes_gcm_nss.cc

Issue 410743002: [refactor] Replace custom utility function with base's "vector_as_array()" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase onto master Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/webcrypto/nss/aes_gcm_nss.cc

diff --git a/content/child/webcrypto/nss/aes_gcm_nss.cc b/content/child/webcrypto/nss/aes_gcm_nss.cc

index 26cbe5f2c66e74bb7472edfa588e5d6710664542..5dfbb08328e711e05252524077fcaa4275ed8f56 100644

--- a/content/child/webcrypto/nss/aes_gcm_nss.cc

+++ b/content/child/webcrypto/nss/aes_gcm_nss.cc

@@ -3,6 +3,7 @@

// found in the LICENSE file.

#include "base/numerics/safe_math.h"

+#include "base/stl_util.h"

#include "content/child/webcrypto/crypto_data.h"

#include "content/child/webcrypto/nss/aes_key_nss.h"

#include "content/child/webcrypto/nss/key_nss.h"

@@ -112,7 +113,7 @@ Status AesGcmEncryptDecrypt(EncryptOrDecrypt mode,

// WebCryptoArrayBuffer is expensive that hack may be worth looking into.

buffer->resize(buffer_size.ValueOrDie());

- unsigned char* buffer_data = Uint8VectorStart(buffer);

+ unsigned char* buffer_data = vector_as_array(buffer);

PK11_EncryptDecryptFunction encrypt_or_decrypt_func =

(mode == ENCRYPT) ? NssRuntimeSupport::Get()->pk11_encrypt_func()

« no previous file with comments | « content/child/webcrypto/nss/aes_cbc_nss.cc ('k') | content/child/webcrypto/nss/hmac_nss.cc » ('j') | no next file with comments »