Issue 410603002: web_dev_style: add presubmit for superfluous </include> tags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 410603002: web_dev_style: add presubmit for superfluous </include> tags. (Closed)

Created:
6 years, 5 months ago by Dan Beam

Modified:
6 years, 5 months ago

Reviewers:
Tyler Breisacher (Chromium)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

web_dev_style: add presubmit for superfluous </include> tags. R=tbreisacher@chromium.org BUG=395905 TEST=chrome/browser/test_presubmit.py NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285138

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -36 lines)			Patch
M	chrome/browser/PRESUBMIT.py	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/test_presubmit.py	View		8 chunks	+57 lines, -14 lines	0 comments	Download
M	chrome/browser/web_dev_style/js_checker.py	View		2 chunks	+5 lines, -21 lines	0 comments	Download
A	chrome/browser/web_dev_style/regex_check.py	View		1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/browser/web_dev_style/resource_checker.py	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/410603002/40001

6 years, 5 months ago (2014-07-24 03:15:57 UTC) #7

Message was sent while issue was closed.

Change committed as 285138