web_dev_style: add presubmit for superfluous </include> tags.

chrome/browser/web_dev_style/js_checker.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Presubmit script for Chromium JS resources.
 
 See chrome/browser/PRESUBMIT.py
 """
 
+import regex_check
+
+
 class JSChecker(object):
   def __init__(self, input_api, output_api, file_filter=None):
     self.input_api = input_api
     self.output_api = output_api
     self.file_filter = file_filter
 
   def RegexCheck(self, line_number, line, regex, message):
-    """Searches for |regex| in |line| to check for a particular style
-       violation, returning a message like the one below if the regex matches.
-       The |regex| must have exactly one capturing group so that the relevant
-       part of |line| can be highlighted. If more groups are needed, use
-       "(?:...)" to make a non-capturing group. Sample message:
-
-       line 6: Use var instead of const.
-           const foo = bar();
-           ^^^^^
-    """
-    match = self.input_api.re.search(regex, line)
-    if match:
-      assert len(match.groups()) == 1
-      start = match.start(1)
-      length = match.end(1) - start
-      return '  line %d: %s\n%s\n%s' % (
-          line_number,
-          message,
-          line,
-          self.error_highlight(start, length))
-    return ''
+    return regex_check.RegexCheck(
+        self.input_api.re, line_number, line, regex, message)
 
   def ChromeSendCheck(self, i, line):
     """Checks for a particular misuse of 'chrome.send'."""
     return self.RegexCheck(i, line, r"chrome\.send\('[^']+'\s*(, \[\])\)",
         'Passing an empty array to chrome.send is unnecessary')
 
   def ConstCheck(self, i, line):
     """Check for use of the 'const' keyword."""
     if self.input_api.re.search(r'\*\s+@const', line):
       # Probably a JsDoc line
@@ skipping 198 matching lines @@
 
     if results:
       results.append(self.output_api.PresubmitNotifyResult(
           'See the JavaScript style guide at '
           'http://www.chromium.org/developers/web-development-style-guide'
           '#TOC-JavaScript and if you have any feedback about the JavaScript '
           'PRESUBMIT check, contact tbreisacher@chromium.org or '
           'dbeam@chromium.org'))
 
     return results