Issue 410533002: Merge 278958 "Discard ChromeViewHostMsg_SearchBox* IPCs if they ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 410533002: Merge 278958 "Discard ChromeViewHostMsg_SearchBox* IPCs if they ..." (Closed)

Created:
6 years, 5 months ago by kmadhusu

Modified:
6 years, 5 months ago

Reviewers:
kmadhusu

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src

Visibility:
Public.

More Reviews

Description

Merge 278958 "Discard ChromeViewHostMsg_SearchBox* IPCs if they ...". Updated the unit test to resolve merge conflict. > Discard ChromeViewHostMsg_SearchBox* IPCs if they not sent from an Instant process. > > Also updated SearchIPCRouterPolicy::ShouldProcessNavigateToURL to restrict the message handling to NTP. > > BUG=387033 > TEST=none > > Review URL: https://codereview.chromium.org/342323008 TBR=kmadhusu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284559

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -19 lines)			Patch
M	chrome/browser/search/search.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/search/search.cc	View	3 chunks	+16 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_policy_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_policy_unittest.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_ipc_router_unittest.cc	View	3 chunks	+25 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

kmadhusu

6 years, 5 months ago (2014-07-22 00:31:33 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r284559 (presubmit successful).

Expand Messages | Collapse Messages