Discard ChromeViewHostMsg_SearchBox* IPCs if they not sent from an Instant process.

Discard ChromeViewHostMsg_SearchBox* IPCs if they not sent from an Instant process. 

Also updated SearchIPCRouterPolicy::ShouldProcessNavigateToURL to restrict the message handling to NTP.

BUG=387033
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278958

[kmadhusu, 2014-06-20 19:20:04]

Please review. Working on tests.

Thanks.

[Jered, 2014-06-20 20:05:45]

On 2014/06/20 19:20:04, kmadhusu wrote:
> Please review. Working on tests.
> 
> Thanks.

lgtm

I think this fixes the basic problem.

[kmadhusu, 2014-06-20 21:13:14]

jered@: Added unit tests. PTAL.

Thanks.

[nasko, 2014-06-20 21:18:02]

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
File chrome/browser/ui/search/search_ipc_router_unittest.cc (right):

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
chrome/browser/ui/search/search_ipc_router_unittest.cc:219:
OnMessageReceived(*message);
How does the test pass/fail here?

[kmadhusu, 2014-06-20 21:20:29]

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
File chrome/browser/ui/search/search_ipc_router_unittest.cc (right):

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
chrome/browser/ui/search/search_ipc_router_unittest.cc:219:
OnMessageReceived(*message);
On 2014/06/20 21:18:02, nasko wrote:
> How does the test pass/fail here?

Test will pass. We expect SearchIPCRouter::OnMessageReceived() to discard the
message (line #190 checks the return value
SearchIPCRouter::OnMessageReceived()).

[nasko, 2014-06-20 21:27:42]

LGTM with a nit.

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
File chrome/browser/ui/search/search_ipc_router_unittest.cc (right):

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
chrome/browser/ui/search/search_ipc_router_unittest.cc:190:
EXPECT_EQ(should_handle_message, handled);
nit: I'd make that an ASSERT, as it is never expected to pass and should be an
immediate test failure.

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
chrome/browser/ui/search/search_ipc_router_unittest.cc:219:
OnMessageReceived(*message);
On 2014/06/20 21:20:28, kmadhusu wrote:
> On 2014/06/20 21:18:02, nasko wrote:
> > How does the test pass/fail here?
> 
> Test will pass. We expect SearchIPCRouter::OnMessageReceived() to discard the
> message (line #190 checks the return value
> SearchIPCRouter::OnMessageReceived()).

Ok, it passes due to the expectations of no calls to ShouldProcessNavigateToURL,
not because of the EXPECT_EQ on line 190.

[kmadhusu, 2014-06-20 21:33:54]

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
File chrome/browser/ui/search/search_ipc_router_unittest.cc (right):

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
chrome/browser/ui/search/search_ipc_router_unittest.cc:190:
EXPECT_EQ(should_handle_message, handled);
On 2014/06/20 21:27:42, nasko wrote:
> nit: I'd make that an ASSERT, as it is never expected to pass and should be an
> immediate test failure.

Done.

https://codereview.chromium.org/342323008/diff/20001/chrome/browser/ui/search...
chrome/browser/ui/search/search_ipc_router_unittest.cc:219:
OnMessageReceived(*message);
On 2014/06/20 21:27:42, nasko wrote:
> On 2014/06/20 21:20:28, kmadhusu wrote:
> > On 2014/06/20 21:18:02, nasko wrote:
> > > How does the test pass/fail here?
> > 
> > Test will pass. We expect SearchIPCRouter::OnMessageReceived() to discard
the
> > message (line #190 checks the return value
> > SearchIPCRouter::OnMessageReceived()).
> 
> Ok, it passes due to the expectations of no calls to
ShouldProcessNavigateToURL,
> not because of the EXPECT_EQ on line 190.

Ack.

[kmadhusu, 2014-06-20 21:42:19]

The CQ bit was checked by kmadhusu@chromium.org

[Jered, 2014-06-20 21:42:45]

On 2014/06/20 21:42:19, kmadhusu wrote:
> The CQ bit was checked by mailto:kmadhusu@chromium.org

slgtm

[commit-bot: I haz the power, 2014-06-20 21:43:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kmadhusu@chromium.org/342323008/40001

[commit-bot: I haz the power, 2014-06-21 13:24:19]

Change committed as 278958