Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1171)

Issue 410413004: Fix handling of icon resources in official RPM packages (Closed)

Created:
6 years, 5 months ago by Paweł Hajdan Jr.
Modified:
3 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix handling of icon resources in official RPM packages BUG=395506

Patch Set 1 #

Total comments: 5

Patch Set 2 : fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/installer/linux/rpm/build.sh View 1 2 chunks +3 lines, -3 lines 1 comment Download
M chrome/installer/linux/rpm/chrome.spec.template View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
6 years, 5 months ago (2014-07-24 14:10:28 UTC) #1
Lei Zhang
https://codereview.chromium.org/410413004/diff/1/chrome/installer/linux/rpm/build.sh File chrome/installer/linux/rpm/build.sh (right): https://codereview.chromium.org/410413004/diff/1/chrome/installer/linux/rpm/build.sh#newcode20 chrome/installer/linux/rpm/build.sh:20: local PACKAGE_FILENAME="${PACKAGE}" If you move this down to after ...
6 years, 5 months ago (2014-07-24 19:25:59 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/410413004/diff/1/chrome/installer/linux/rpm/build.sh File chrome/installer/linux/rpm/build.sh (right): https://codereview.chromium.org/410413004/diff/1/chrome/installer/linux/rpm/build.sh#newcode20 chrome/installer/linux/rpm/build.sh:20: local PACKAGE_FILENAME="${PACKAGE}" On 2014/07/24 19:25:58, Lei Zhang wrote: > ...
6 years, 5 months ago (2014-07-25 10:51:29 UTC) #3
Lei Zhang
6 years, 4 months ago (2014-07-30 03:30:25 UTC) #4
https://codereview.chromium.org/410413004/diff/1/chrome/installer/linux/rpm/b...
File chrome/installer/linux/rpm/build.sh (right):

https://codereview.chromium.org/410413004/diff/1/chrome/installer/linux/rpm/b...
chrome/installer/linux/rpm/build.sh:155:
PKGNAME="${PACKAGE}-${VERSION}-${PACKAGE_RELEASE}"
On 2014/07/25 10:51:29, Paweł Hajdan Jr. wrote:
> Eventually I'd like to rewrite this in python instead of bash for better
> maintainability.

(General observation) I think a lot of the confusion comes from statements like:

PACKAGE="${PACKAGE}-${CHANNEL}"

So at any point in the program, it is not obvious what $PACKAGE is really
referring to.

I think what we should do is to not change $PACKAGE, but instead, create a
$PACKAGE_CHANNEL variable and use that where appropriate.

You probably have to fix the debian side as while you are at it, but that should
also fix bug 354571.

https://codereview.chromium.org/410413004/diff/20001/chrome/installer/linux/r...
File chrome/installer/linux/rpm/build.sh (right):

https://codereview.chromium.org/410413004/diff/20001/chrome/installer/linux/r...
chrome/installer/linux/rpm/build.sh:18: # Trunk packages need to install to a
custom path so they don't conflict with
This comment needs to be updated.

Powered by Google App Engine
This is Rietveld 408576698