runtime/vm/assembler_arm64.h - Issue 410333003: Shorter TryAllocate instruction sequence on ARM/ARM64/MIPS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_arm64.h

Issue 410333003: Shorter TryAllocate instruction sequence on ARM/ARM64/MIPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_arm64.h

diff --git a/runtime/vm/assembler_arm64.h b/runtime/vm/assembler_arm64.h

index 03224f68f373e43177bb922351f953c09da032bf..ac082d1913bdfafd7b95f1088a3a6f7b06c2f458 100644

--- a/runtime/vm/assembler_arm64.h

+++ b/runtime/vm/assembler_arm64.h

@@ -431,6 +431,7 @@ class Assembler : public ValueObject {

static void InitializeMemoryWithBreakpoints(uword data, intptr_t length);

void Comment(const char* format, ...) PRINTF_ATTRIBUTE(2, 3);

+ static bool EmittingComments();

const Code::Comments& GetCodeComments() const;

@@ -1217,6 +1218,7 @@ class Assembler : public ValueObject {

void TryAllocate(const Class& cls,

Label* failure,

+ Register temp_reg,

regis 2014/07/23 22:29:33 Not required. We have 2 temp registers on ARM64: T

Address ElementAddressForIntIndex(bool is_external,

« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_arm64.cc » ('j') | runtime/vm/assembler_arm64.cc » ('J')