Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Side by Side Diff: runtime/vm/assembler_arm64.h

Issue 410333003: Shorter TryAllocate instruction sequence on ARM/ARM64/MIPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ASSEMBLER_ARM64_H_ 5 #ifndef VM_ASSEMBLER_ARM64_H_
6 #define VM_ASSEMBLER_ARM64_H_ 6 #define VM_ASSEMBLER_ARM64_H_
7 7
8 #ifndef VM_ASSEMBLER_H_ 8 #ifndef VM_ASSEMBLER_H_
9 #error Do not include assembler_arm64.h directly; use assembler.h instead. 9 #error Do not include assembler_arm64.h directly; use assembler.h instead.
10 #endif 10 #endif
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 424
425 // Debugging and bringup support. 425 // Debugging and bringup support.
426 void Stop(const char* message); 426 void Stop(const char* message);
427 void Unimplemented(const char* message); 427 void Unimplemented(const char* message);
428 void Untested(const char* message); 428 void Untested(const char* message);
429 void Unreachable(const char* message); 429 void Unreachable(const char* message);
430 430
431 static void InitializeMemoryWithBreakpoints(uword data, intptr_t length); 431 static void InitializeMemoryWithBreakpoints(uword data, intptr_t length);
432 432
433 void Comment(const char* format, ...) PRINTF_ATTRIBUTE(2, 3); 433 void Comment(const char* format, ...) PRINTF_ATTRIBUTE(2, 3);
434 static bool EmittingComments();
434 435
435 const Code::Comments& GetCodeComments() const; 436 const Code::Comments& GetCodeComments() const;
436 437
437 static const char* RegisterName(Register reg); 438 static const char* RegisterName(Register reg);
438 439
439 static const char* FpuRegisterName(FpuRegister reg); 440 static const char* FpuRegisterName(FpuRegister reg);
440 441
441 void SetPrologueOffset() { 442 void SetPrologueOffset() {
442 if (prologue_offset_ == -1) { 443 if (prologue_offset_ == -1) {
443 prologue_offset_ = CodeSize(); 444 prologue_offset_ = CodeSize();
(...skipping 766 matching lines...) Expand 10 before | Expand all | Expand 10 after
1210 Register pp, 1211 Register pp,
1211 Heap::Space space = Heap::kNew); 1212 Heap::Space space = Heap::kNew);
1212 1213
1213 // Inlined allocation of an instance of class 'cls', code has no runtime 1214 // Inlined allocation of an instance of class 'cls', code has no runtime
1214 // calls. Jump to 'failure' if the instance cannot be allocated here. 1215 // calls. Jump to 'failure' if the instance cannot be allocated here.
1215 // Allocated instance is returned in 'instance_reg'. 1216 // Allocated instance is returned in 'instance_reg'.
1216 // Only the tags field of the object is initialized. 1217 // Only the tags field of the object is initialized.
1217 void TryAllocate(const Class& cls, 1218 void TryAllocate(const Class& cls,
1218 Label* failure, 1219 Label* failure,
1219 Register instance_reg, 1220 Register instance_reg,
1221 Register temp_reg,
regis 2014/07/23 22:29:33 Not required. We have 2 temp registers on ARM64: T
1220 Register pp); 1222 Register pp);
1221 1223
1222 Address ElementAddressForIntIndex(bool is_external, 1224 Address ElementAddressForIntIndex(bool is_external,
1223 intptr_t cid, 1225 intptr_t cid,
1224 intptr_t index_scale, 1226 intptr_t index_scale,
1225 Register array, 1227 Register array,
1226 intptr_t index) const; 1228 intptr_t index) const;
1227 Address ElementAddressForRegIndex(bool is_load, 1229 Address ElementAddressForRegIndex(bool is_load,
1228 bool is_external, 1230 bool is_external,
1229 intptr_t cid, 1231 intptr_t cid,
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
1685 Register value, 1687 Register value,
1686 Label* no_update); 1688 Label* no_update);
1687 1689
1688 DISALLOW_ALLOCATION(); 1690 DISALLOW_ALLOCATION();
1689 DISALLOW_COPY_AND_ASSIGN(Assembler); 1691 DISALLOW_COPY_AND_ASSIGN(Assembler);
1690 }; 1692 };
1691 1693
1692 } // namespace dart 1694 } // namespace dart
1693 1695
1694 #endif // VM_ASSEMBLER_ARM64_H_ 1696 #endif // VM_ASSEMBLER_ARM64_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698