Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: runtime/vm/assembler.cc

Issue 410333003: Shorter TryAllocate instruction sequence on ARM/ARM64/MIPS. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.h » ('j') | runtime/vm/assembler_arm64.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler.cc
diff --git a/runtime/vm/assembler.cc b/runtime/vm/assembler.cc
index 65e56276cd11ae4fb71cdb65e75c3ce3a2908ec7..f259071c1d824dc7e0523ec3e769ac6dfac2ea78 100644
--- a/runtime/vm/assembler.cc
+++ b/runtime/vm/assembler.cc
@@ -210,7 +210,7 @@ void Assembler::Unreachable(const char* message) {
void Assembler::Comment(const char* format, ...) {
- if (FLAG_code_comments || FLAG_disassemble || FLAG_disassemble_optimized) {
+ if (EmittingComments()) {
char buffer[1024];
va_list args;
@@ -225,6 +225,11 @@ void Assembler::Comment(const char* format, ...) {
}
+bool Assembler::EmittingComments() {
+ return FLAG_code_comments || FLAG_disassemble || FLAG_disassemble_optimized;
+}
+
+
const Code::Comments& Assembler::GetCodeComments() const {
Code::Comments& comments = Code::Comments::New(comments_.length());
« no previous file with comments | « no previous file | runtime/vm/assembler_arm.h » ('j') | runtime/vm/assembler_arm64.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698