Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: test/cctest/test-debug.cc

Issue 410153002: Make --always-opt also optimize toplevel code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Jacob Bramley. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-decls.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 6623a3ed95e7d242841615860fe5360e9242a92b..ad22411b85e8dd585041e65bfeefb9bacd3c5057 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -6624,6 +6624,10 @@ TEST(Backtrace) {
v8::Debug::SetMessageHandler(BacktraceData::MessageHandler);
+ // TODO(mstarzinger): This doesn't work with --always-opt because we don't
+ // have correct source positions in optimized code. Enable once we have.
+ i::FLAG_always_opt = false;
+
const int kBufferSize = 1000;
uint16_t buffer[kBufferSize];
const char* scripts_command =
@@ -6962,13 +6966,12 @@ TEST(DeoptimizeDuringDebugBreak) {
v8::Debug::SetDebugEventListener(DebugEventBreakDeoptimize);
// Compile and run function bar which will optimize it for some flag settings.
- v8::Script::Compile(v8::String::NewFromUtf8(
- env->GetIsolate(), "function bar(){}; bar()"))->Run();
+ v8::Local<v8::Function> f = CompileFunction(&env, "function bar(){}", "bar");
+ f->Call(v8::Undefined(env->GetIsolate()), 0, NULL);
// Set debug break and call bar again.
v8::Debug::DebugBreak(env->GetIsolate());
- v8::Script::Compile(v8::String::NewFromUtf8(env->GetIsolate(), "bar()"))
- ->Run();
+ f->Call(v8::Undefined(env->GetIsolate()), 0, NULL);
CHECK(debug_event_break_deoptimize_done);
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-decls.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698