test/cctest/test-api.cc - Issue 410153002: Make --always-opt also optimize toplevel code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 410153002: Make --always-opt also optimize toplevel code. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Jacob Bramley. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index c8b8900e62fac25625e6893a91d51449801f3db8..dbd1358a1448b4c69009f1c7e618a93682a50595 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -5369,7 +5369,8 @@ void TryCatchMixedNestingCheck(v8::TryCatch* try_catch) {

CHECK_EQ(0, strcmp(*v8::String::Utf8Value(message->Get()),

"Uncaught Error: a"));

CHECK_EQ(1, message->GetLineNumber());

- CHECK_EQ(6, message->GetStartColumn());

+ // TODO(mstarzinger): Our compilers disagree about the position.

+ CHECK_EQ(i::FLAG_always_opt ? 0 : 6, message->GetStartColumn());

}

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »