Issue 41003003: Remove virtual destructors for CSSMatrix and CSSVariablesMap

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 41003003: Remove virtual destructors for CSSMatrix and CSSVariablesMap (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium, Julien - ping for review

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove virtual destructors for CSSMatrix and CSSVariablesMap Remove destructors for CSSMatrix and CSSVariablesMap as these were empty and marked as virtual. This avoids creating an unnecessary vtable as these classes are never subclasses nor do they have any virtual function. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160482

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -8 lines)			Patch
M	Source/core/css/CSSMatrix.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSMatrix.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/css/CSSVariablesMap.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Julien - ping for review

lgtm, the empty BUG= is usually removed from the description.

7 years, 2 months ago (2013-10-24 18:26:25 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/41003003/1

7 years, 2 months ago (2013-10-24 18:30:44 UTC) #3

Message was sent while issue was closed.

Change committed as 160482

Expand Messages | Collapse Messages