Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: Source/core/css/CSSMatrix.cpp

Issue 41003003: Remove virtual destructors for CSSMatrix and CSSVariablesMap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSMatrix.h ('k') | Source/core/css/CSSVariablesMap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 { 42 {
43 ScriptWrappable::init(this); 43 ScriptWrappable::init(this);
44 } 44 }
45 45
46 CSSMatrix::CSSMatrix(const String& s, ExceptionState& es) 46 CSSMatrix::CSSMatrix(const String& s, ExceptionState& es)
47 { 47 {
48 ScriptWrappable::init(this); 48 ScriptWrappable::init(this);
49 setMatrixValue(s, es); 49 setMatrixValue(s, es);
50 } 50 }
51 51
52 CSSMatrix::~CSSMatrix()
53 {
54 }
55
56 void CSSMatrix::setMatrixValue(const String& string, ExceptionState& es) 52 void CSSMatrix::setMatrixValue(const String& string, ExceptionState& es)
57 { 53 {
58 if (string.isEmpty()) 54 if (string.isEmpty())
59 return; 55 return;
60 56
61 RefPtr<MutableStylePropertySet> styleDeclaration = MutableStylePropertySet:: create(); 57 RefPtr<MutableStylePropertySet> styleDeclaration = MutableStylePropertySet:: create();
62 if (CSSParser::parseValue(styleDeclaration.get(), CSSPropertyWebkitTransform , string, true, HTMLStandardMode, 0)) { 58 if (CSSParser::parseValue(styleDeclaration.get(), CSSPropertyWebkitTransform , string, true, HTMLStandardMode, 0)) {
63 // Convert to TransformOperations. This can fail if a property 59 // Convert to TransformOperations. This can fail if a property
64 // requires style (i.e., param uses 'ems' or 'exs') 60 // requires style (i.e., param uses 'ems' or 'exs')
65 RefPtr<CSSValue> value = styleDeclaration->getPropertyCSSValue(CSSProper tyWebkitTransform); 61 RefPtr<CSSValue> value = styleDeclaration->getPropertyCSSValue(CSSProper tyWebkitTransform);
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 if (m_matrix.isAffine()) 181 if (m_matrix.isAffine())
186 return String::format("matrix(%f, %f, %f, %f, %f, %f)", m_matrix.a(), m_ matrix.b(), m_matrix.c(), m_matrix.d(), m_matrix.e(), m_matrix.f()); 182 return String::format("matrix(%f, %f, %f, %f, %f, %f)", m_matrix.a(), m_ matrix.b(), m_matrix.c(), m_matrix.d(), m_matrix.e(), m_matrix.f());
187 return String::format("matrix3d(%f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f)", 183 return String::format("matrix3d(%f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f, %f)",
188 m_matrix.m11(), m_matrix.m12(), m_matrix.m13(), m_matrix.m14(), 184 m_matrix.m11(), m_matrix.m12(), m_matrix.m13(), m_matrix.m14(),
189 m_matrix.m21(), m_matrix.m22(), m_matrix.m23(), m_matrix.m24(), 185 m_matrix.m21(), m_matrix.m22(), m_matrix.m23(), m_matrix.m24(),
190 m_matrix.m31(), m_matrix.m32(), m_matrix.m33(), m_matrix.m34(), 186 m_matrix.m31(), m_matrix.m32(), m_matrix.m33(), m_matrix.m34(),
191 m_matrix.m41(), m_matrix.m42(), m_matrix.m43(), m_matrix.m44()); 187 m_matrix.m41(), m_matrix.m42(), m_matrix.m43(), m_matrix.m44());
192 } 188 }
193 189
194 } // namespace WebCore 190 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/CSSMatrix.h ('k') | Source/core/css/CSSVariablesMap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698