chrome/common/extensions/permissions/chrome_permission_message_provider.cc - Issue 410023002: Show read-only messages for non-interact non-desktop Automation extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

Issue 410023002: Show read-only messages for non-interact non-desktop Automation extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Review comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/automation_unittest.cc ('k') | chrome/test/data/extensions/manifest_tests/automation_all_hosts_interact_false.json » ('j') | extensions/common/permissions/permission_message_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

index f28180608dcae30229091b3a7527adfb858b1685..9d12ba4b4ab7ed42ca70dd7247686c6964e98c98 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

@@ -373,7 +373,8 @@ ChromePermissionMessageProvider::GetHostPermissionMessages(

std::set<std::string> hosts =

permission_message_util::GetDistinctHosts(regular_hosts, true, true);

if (!hosts.empty())

- messages.insert(permission_message_util::CreateFromHostList(hosts));

+ messages.insert(permission_message_util::CreateFromHostList(

+ hosts, permission_message_util::kReadWrite));

}

return messages;

}