Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: extensions/common/permissions/permission_message_util.h

Issue 410023002: Show read-only messages for non-interact non-desktop Automation extensions (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Review comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/permissions/permission_message_util.h
diff --git a/extensions/common/permissions/permission_message_util.h b/extensions/common/permissions/permission_message_util.h
index 410e1a2816696ff4afa704d719211ddc3d0ccd1c..2392e455246f9733797963dc24bb2913fc1cd2ca 100644
--- a/extensions/common/permissions/permission_message_util.h
+++ b/extensions/common/permissions/permission_message_util.h
@@ -16,15 +16,22 @@ class URLPatternSet;
namespace permission_message_util {
+enum PermissionMessageProperties {
+ kReadOnly = 0,
not at google - send to devlin 2014/07/25 20:40:03 is the = 0, =1 really necessary?
aboxhall 2014/07/25 20:54:22 Done.
+ kReadWrite = 1
+};
+
// Creates the corresponding permission message for a list of hosts.
-// The messages change depending on what hosts are present.
+// The messages change depending on how many hosts are present, and whether
+// |read_only| is true.
extensions::PermissionMessage CreateFromHostList(
- const std::set<std::string>& hosts);
+ const std::set<std::string>& hosts,
+ PermissionMessageProperties);
-std::set<std::string> GetDistinctHosts(
- const extensions::URLPatternSet& host_patterns,
- bool include_rcd,
- bool exclude_file_scheme);
+ std::set<std::string> GetDistinctHosts(
+ const extensions::URLPatternSet& host_patterns,
+ bool include_rcd,
+ bool exclude_file_scheme);
not at google - send to devlin 2014/07/25 20:40:03 was this clang-format? it shouldn't be indented.
} // namespace permission_message_util

Powered by Google App Engine
This is Rietveld 408576698