Issue 409983002: Revert 284725 "Use ExtensionRegistryObserver instead of DEPRECAT..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409983002: Revert 284725 "Use ExtensionRegistryObserver instead of DEPRECAT..." (Closed)

Created:
6 years, 5 months ago by sky

Modified:
6 years, 5 months ago

Reviewers:
limasdf

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 284725 "Use ExtensionRegistryObserver instead of DEPRECAT..." This appears to have broke StackedPanelBrowserTest.AddNewPanelFromDifferentProfile on windows interactive. http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/15556/steps/interactive_ui_tests/logs/AddNewPanelFromDifferentProfile [ RUN ] StackedPanelBrowserTest.AddNewPanelFromDifferentProfile Backtrace: extensions::ExtensionRegistry::RemoveObserver [0x00000001430B3030+32] (No symbol) [0x00000000086491C0] base::SupportsWeakPtr\u003CObserverListBase\u003Caura::WindowObserver> >::AsWeakPtr [0x000007FEEF42B175+85] StackedPanelBrowserTest.AddNewPanelFromDifferentProfile (run #2): ... > Use ExtensionRegistryObserver instead of DEPRECATED extension notify. > > BUG=354458 > > Review URL: https://codereview.chromium.org/262223003 TBR=limasdf@gmail.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284769

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -35 lines)			Patch
M	trunk/src/chrome/browser/ui/panels/panel.h	View	6 chunks	+1 line, -16 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/panels/panel.cc	View	5 chunks	+7 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/panels/panel_browsertest.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r284769.