Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 262223003: Use ExtensionRegistryObserver instead of DEPRECATED extension notify. (Closed)

Created:
6 years, 7 months ago by limasdf
Modified:
5 years, 3 months ago
Reviewers:
Dmitry Titov, jianli
CC:
chromium-reviews, jennb, jianli, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use ExtensionRegistryObserver instead of DEPRECATED extension notify. BUG=354458 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284725

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M chrome/browser/ui/panels/panel.h View 6 chunks +16 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 5 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 1 2 3 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
limasdf
ptal
6 years, 7 months ago (2014-05-06 15:12:52 UTC) #1
limasdf
ping. could you kindly take a look?
6 years, 7 months ago (2014-05-11 11:13:27 UTC) #2
limasdf
add @jianli for the review. Could you take a look?
6 years, 7 months ago (2014-05-16 09:20:09 UTC) #3
limasdf
ping again?
6 years, 5 months ago (2014-07-08 13:24:40 UTC) #4
Dmitry Titov
Thanks! LGTM
6 years, 5 months ago (2014-07-08 17:01:12 UTC) #5
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 5 months ago (2014-07-10 14:02:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/262223003/40001
6 years, 5 months ago (2014-07-10 14:03:42 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-10 15:14:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-10 15:19:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_dbg/builds/40015)
6 years, 5 months ago (2014-07-10 15:19:49 UTC) #10
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 5 months ago (2014-07-22 15:59:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/262223003/100001
6 years, 5 months ago (2014-07-22 16:00:36 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 18:03:11 UTC) #13
Message was sent while issue was closed. 
Change committed as 284725

Powered by Google App Engine
This is Rietveld 408576698