Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 409883009: GN: Fix extra escaping of rpath=$ORIGIN/lib ldflag (Closed)

Created:
6 years, 5 months ago by jamesr
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, cc-bugs_chromium.org
Project:
chromium
Visibility:
Public.

Description

GN: Fix extra escaping of rpath=$ORIGIN/lib ldflag As written the argument ended up in the .ninja file as \\\$$ORIGIN/lib/ but we want \$$ORIGIN/lib/ to match gyp. R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/config/gcc/BUILD.gn View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jamesr
6 years, 5 months ago (2014-07-23 01:14:47 UTC) #1
brettw
Ah! This broke when I added proper escaping. Thanks for tracking it down. LGTM
6 years, 5 months ago (2014-07-23 04:17:55 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 5 months ago (2014-07-23 04:20:47 UTC) #3
jamesr
On 2014/07/23 04:17:55, brettw wrote: > Ah! This broke when I added proper escaping. Thanks ...
6 years, 5 months ago (2014-07-23 04:21:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/409883009/1
6 years, 5 months ago (2014-07-23 04:23:14 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-23 05:58:52 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 08:57:31 UTC) #7
Message was sent while issue was closed.
Change committed as 284888

Powered by Google App Engine
This is Rietveld 408576698