Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/gcc/BUILD.gn

Issue 409883009: GN: Fix extra escaping of rpath=$ORIGIN/lib ldflag (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/gcc/BUILD.gn
diff --git a/build/config/gcc/BUILD.gn b/build/config/gcc/BUILD.gn
index d5b9ddb4579d1781b3d359ba6538483221f1c5da..c9639ad91cf3ba96691ec86474b342346584aa79 100644
--- a/build/config/gcc/BUILD.gn
+++ b/build/config/gcc/BUILD.gn
@@ -21,9 +21,8 @@ config("symbol_visibility_hidden") {
# Settings for executables and shared libraries.
config("executable_ldconfig") {
ldflags = [
- # Want to pass "\$". Need to escape both '\' and '$'. GN will re-escape as
- # required for ninja.
- "-Wl,-rpath=\\\$ORIGIN/lib/",
+ # Want to pass "\$". GN will re-escape as required for ninja.
+ "-Wl,-rpath=\$ORIGIN/lib/",
"-Wl,-rpath-link=lib/",
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698