GCM: D-Bus methods for wake-on-packet

chromeos/dbus/shill_manager_client.cc

Index: chromeos/dbus/shill_manager_client.cc
diff --git a/chromeos/dbus/shill_manager_client.cc b/chromeos/dbus/shill_manager_client.cc
index 0ad602f22bbb52656ea07c47ee1b11451972b10f..6ed2330fa8f821bf58d52d82a1fcf01945d8cb8b 100644
--- a/chromeos/dbus/shill_manager_client.cc
+++ b/chromeos/dbus/shill_manager_client.cc
@@ -14,6 +14,7 @@
 #include "dbus/object_path.h"
 #include "dbus/object_proxy.h"
 #include "dbus/values_util.h"
+#include "net/base/ip_endpoint.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
@@ -210,6 +211,44 @@ class ShillManagerClientImpl : public ShillManagerClient {
                                             error_callback);
   }
 
+  virtual void AddWakeOnPacketConnection(
+      const net::IPEndPoint& ip_endpoint,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) OVERRIDE {
+    dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
+                                 shill::kAddWakeOnPacketConnectionFunction);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(ip_endpoint.ToString());
+    helper_->CallVoidMethodWithErrorCallback(&method_call,
+                                             callback,
+                                             error_callback);
+  }
+
+  virtual void RemoveWakeOnPacketConnection(
+      const net::IPEndPoint& ip_endpoint,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) OVERRIDE {
+    dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
+                                 shill::kRemoveWakeOnPacketConnectionFunction);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(ip_endpoint.ToString());
+    helper_->CallVoidMethodWithErrorCallback(&method_call,
+                                             callback,
+                                             error_callback);
+  }
+
+  virtual void RemoveAllWakeOnPacketConnections(
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) OVERRIDE {
+    dbus::MethodCall method_call(
+        shill::kFlimflamManagerInterface,
+        shill::kRemoveAllWakeOnPacketConnectionsFunction);
+    dbus::MessageWriter writer(&method_call);

[Daniel Erat, 2014/08/23 14:44:52]

you don't need this MessageWriter

[Luigi Semenzato, 2014/08/25 19:59:34]

Thanks.  (Why no compiler warning?  Possible side effects in constructor?
Still...)

+    helper_->CallVoidMethodWithErrorCallback(&method_call,
+                                             callback,
+                                             error_callback);
+  }
+
   virtual TestInterface* GetTestInterface() OVERRIDE {
     return NULL;
   }