GCM: D-Bus methods for wake-on-packet

chromeos/dbus/shill_manager_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/shill_manager_client.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/values.h"
 #include "chromeos/dbus/shill_property_changed_observer.h"
 #include "dbus/bus.h"
 #include "dbus/message.h"
 #include "dbus/object_path.h"
 #include "dbus/object_proxy.h"
 #include "dbus/values_util.h"
+#include "net/base/ip_endpoint.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 
 namespace {
 
 // The ShillManagerClient implementation.
 class ShillManagerClientImpl : public ShillManagerClient {
  public:
   ShillManagerClientImpl() : proxy_(NULL) {}
@@ skipping 176 matching lines @@
   virtual void ConnectToBestServices(
       const base::Closure& callback,
       const ErrorCallback& error_callback) OVERRIDE {
     dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
                                  shill::kConnectToBestServicesFunction);
     helper_->CallVoidMethodWithErrorCallback(&method_call,
                                             callback,
                                             error_callback);
   }
 
+  virtual void AddWakeOnPacketConnection(
+      const net::IPEndPoint& ip_endpoint,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) OVERRIDE {
+    dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
+                                 shill::kAddWakeOnPacketConnectionFunction);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(ip_endpoint.ToString());
+    helper_->CallVoidMethodWithErrorCallback(&method_call,
+                                             callback,
+                                             error_callback);
+  }
+
+  virtual void RemoveWakeOnPacketConnection(
+      const net::IPEndPoint& ip_endpoint,
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) OVERRIDE {
+    dbus::MethodCall method_call(shill::kFlimflamManagerInterface,
+                                 shill::kRemoveWakeOnPacketConnectionFunction);
+    dbus::MessageWriter writer(&method_call);
+    writer.AppendString(ip_endpoint.ToString());
+    helper_->CallVoidMethodWithErrorCallback(&method_call,
+                                             callback,
+                                             error_callback);
+  }
+
+  virtual void RemoveAllWakeOnPacketConnections(
+      const base::Closure& callback,
+      const ErrorCallback& error_callback) OVERRIDE {
+    dbus::MethodCall method_call(
+        shill::kFlimflamManagerInterface,
+        shill::kRemoveAllWakeOnPacketConnectionsFunction);
+    dbus::MessageWriter writer(&method_call);

[Daniel Erat, 2014/08/23 14:44:52]

you don't need this MessageWriter

[Luigi Semenzato, 2014/08/25 19:59:34]

Thanks.  (Why no compiler warning?  Possible side effects in constructor?
Still...)

+    helper_->CallVoidMethodWithErrorCallback(&method_call,
+                                             callback,
+                                             error_callback);
+  }
+
   virtual TestInterface* GetTestInterface() OVERRIDE {
     return NULL;
   }
 
  protected:
   virtual void Init(dbus::Bus* bus) OVERRIDE {
     proxy_ = bus->GetObjectProxy(shill::kFlimflamServiceName,
                                  dbus::ObjectPath(shill::kFlimflamServicePath));
     helper_.reset(new ShillClientHelper(proxy_));
     helper_->MonitorPropertyChanged(shill::kFlimflamManagerInterface);
@@ skipping 18 matching lines @@
 }
 
 // ShillManagerClient::VerificationProperties implementation.
 ShillManagerClient::VerificationProperties::VerificationProperties() {
 }
 
 ShillManagerClient::VerificationProperties::~VerificationProperties() {
 }
 
 }  // namespace chromeos