GCM: D-Bus methods for wake-on-packet

chrome/browser/services/gcm/gcm_profile_service.cc

Index: chrome/browser/services/gcm/gcm_profile_service.cc
diff --git a/chrome/browser/services/gcm/gcm_profile_service.cc b/chrome/browser/services/gcm/gcm_profile_service.cc
index e431d8dcb56063034908d189293b21ce40727e17..aca1cf6ae2e82e457df2a2f31fc6801a5df32393 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.cc
+++ b/chrome/browser/services/gcm/gcm_profile_service.cc
@@ -14,6 +14,9 @@
 #include "components/gcm_driver/gcm_driver_android.h"
 #else
 #include "base/files/file_path.h"
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/services/gcm/chromeos_gcm_app_handler.h"
+#endif
 #include "chrome/browser/services/gcm/gcm_desktop_utils.h"
 #include "chrome/browser/signin/profile_identity_provider.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
@@ -121,6 +124,11 @@ GCMProfileService::GCMProfileService(
       profile_->GetPath().Append(chrome::kGCMStoreDirname),
       profile_->GetRequestContext());
 
+#ifdef CHROMEOS
+  driver_->AddAppHandler("ChromeOSGCMAppHandler",
+                         new gcm::ChromeOSGCMAppHandler());

[Nicolas Zea, 2014/08/21 21:22:19]

Note that this will leak, as the driver doesn't take ownership of any app
handlers provided to it. Also, we should be careful about which app id we give
it, and make sure it uses a namespace reserved for internal apps.

Filip, I believe Android already does something similar, by reserving certain
prefixes?

[fgorski, 2014/08/21 21:38:26]

there is no namespace specified for that purpose.
Sync uses com.google.chrome.invalidations for invalidations
we can probably have one for chrome OS like that.
com.google.chrome.chromeos (or something specific to sleep)

[Luigi Semenzato, 2014/08/22 01:08:19]

Done, although I suspect the app id needs to be defined as a constant.

+#endif
+
   identity_observer_.reset(new IdentityObserver(profile, driver_.get()));
 }
 #endif  // defined(OS_ANDROID)