GCM: D-Bus methods for wake-on-packet

chrome/browser/services/gcm/gcm_profile_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/gcm_profile_service.h"
 
 #include "base/logging.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 
 #if defined(OS_ANDROID)
 #include "components/gcm_driver/gcm_driver_android.h"
 #else
 #include "base/files/file_path.h"
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/services/gcm/chromeos_gcm_app_handler.h"
+#endif
 #include "chrome/browser/services/gcm/gcm_desktop_utils.h"
 #include "chrome/browser/signin/profile_identity_provider.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
 #include "chrome/common/chrome_constants.h"
 #include "components/gcm_driver/gcm_client_factory.h"
 #include "components/signin/core/browser/signin_manager.h"
 #include "google_apis/gaia/identity_provider.h"
 #include "net/url_request/url_request_context_getter.h"
@@ skipping 87 matching lines @@
     scoped_ptr<GCMClientFactory> gcm_client_factory)
     : profile_(profile),
       push_messaging_service_(this) {
   DCHECK(!profile->IsOffTheRecord());
 
   driver_ = CreateGCMDriverDesktop(
       gcm_client_factory.Pass(),
       profile_->GetPath().Append(chrome::kGCMStoreDirname),
       profile_->GetRequestContext());
 
+#ifdef CHROMEOS
+  driver_->AddAppHandler("ChromeOSGCMAppHandler",
+                         new gcm::ChromeOSGCMAppHandler());

[Nicolas Zea, 2014/08/21 21:22:19]

Note that this will leak, as the driver doesn't take ownership of any app
handlers provided to it. Also, we should be careful about which app id we give
it, and make sure it uses a namespace reserved for internal apps.

Filip, I believe Android already does something similar, by reserving certain
prefixes?

[fgorski, 2014/08/21 21:38:26]

there is no namespace specified for that purpose.
Sync uses com.google.chrome.invalidations for invalidations
we can probably have one for chrome OS like that.
com.google.chrome.chromeos (or something specific to sleep)

[Luigi Semenzato, 2014/08/22 01:08:19]

Done, although I suspect the app id needs to be defined as a constant.

+#endif
+
   identity_observer_.reset(new IdentityObserver(profile, driver_.get()));
 }
 #endif  // defined(OS_ANDROID)
 
 GCMProfileService::GCMProfileService()
     : profile_(NULL),
       push_messaging_service_(this) {
 }
 
 GCMProfileService::~GCMProfileService() {
@@ skipping 35 matching lines @@
   return identity_observer_ ? identity_observer_->SignedInUserName()
                             : std::string();
 #endif  // defined(OS_ANDROID)
 }
 
 void GCMProfileService::SetDriverForTesting(GCMDriver* driver) {
   driver_.reset(driver);
 }
 
 }  // namespace gcm