GCM: D-Bus methods for wake-on-packet

chrome/browser/services/gcm/gcm_profile_service_unittest.cc

Index: chrome/browser/services/gcm/gcm_profile_service_unittest.cc
diff --git a/chrome/browser/services/gcm/gcm_profile_service_unittest.cc b/chrome/browser/services/gcm/gcm_profile_service_unittest.cc
index 3d77031d2a30d9821412203258727f4d6a94cb27..13c9ad58bad73c285c6e2c18e8a0c3f4a0f80ee6 100644
--- a/chrome/browser/services/gcm/gcm_profile_service_unittest.cc
+++ b/chrome/browser/services/gcm/gcm_profile_service_unittest.cc
@@ -15,6 +15,8 @@
 #include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/test/base/testing_profile.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/fake_shill_manager_client.h"
 #include "components/gcm_driver/fake_gcm_app_handler.h"
 #include "components/gcm_driver/fake_gcm_client.h"
 #include "components/gcm_driver/fake_gcm_client_factory.h"
@@ -120,6 +122,8 @@ void GCMProfileServiceTest::SetUp() {
   builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
                             FakeSigninManager::Build);
   profile_ = builder.Build();
+  // Create a DBus thread manager setter for its side effect.
+  (void) chromeos::DBusThreadManager::GetSetterForTesting();

[Chirantan Ekbote, 2014/09/12 00:52:16]

This is causing the build to fail on non-chrome os systems:

obj/chrome/browser/services/gcm/unit_tests.gcm_profile_service_unittest.o:../../chrome/browser/services/gcm/gcm_profile_service_unittest.cc:function
gcm::GCMProfileServiceTest::SetUp():error: undefined reference to
'chromeos::DBusThreadManager::GetSetterForTesting()'
obj/chrome/browser/services/gcm/unit_tests.gcm_profile_service_unittest.o:../../chrome/browser/services/gcm/gcm_profile_service_unittest.cc:function
gcm::GCMProfileServiceTest::SetUp():error: undefined reference to
'chromeos::DBusThreadManagerSetter::~DBusThreadManagerSetter()'


You could use an #if defined(OS_CHROMEOS) here or you could move the
ChromeOSGCMConnectionObserver into chrome/browser/chromeos/net and have it be
owned by ChromeBrowserMainPartsChromeos.  My preference is for the latter since
then you probably wouldn't need to init the DBusThreadManager here.

[Luigi Semenzato, 2014/09/12 01:24:21]

Thank you Chirantan.  I am tempted to use #ifdef OS_CHROMEOS instead of moving
that class one more time.

 }
 
 void GCMProfileServiceTest::TearDown() {