GCM: D-Bus methods for wake-on-packet

chrome/browser/services/gcm/gcm_profile_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/gcm_profile_service.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "chrome/browser/services/gcm/fake_signin_manager.h"
 #include "chrome/browser/services/gcm/gcm_profile_service_factory.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/test/base/testing_profile.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/fake_shill_manager_client.h"
 #include "components/gcm_driver/fake_gcm_app_handler.h"
 #include "components/gcm_driver/fake_gcm_client.h"
 #include "components/gcm_driver/fake_gcm_client_factory.h"
 #include "components/gcm_driver/gcm_client.h"
 #include "components/gcm_driver/gcm_client_factory.h"
 #include "components/gcm_driver/gcm_driver.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
@@ skipping 85 matching lines @@
 FakeGCMClient* GCMProfileServiceTest::GetGCMClient() const {
   return static_cast<FakeGCMClient*>(
       gcm_profile_service_->driver()->GetGCMClientForTesting());
 }
 
 void GCMProfileServiceTest::SetUp() {
   TestingProfile::Builder builder;
   builder.AddTestingFactory(SigninManagerFactory::GetInstance(),
                             FakeSigninManager::Build);
   profile_ = builder.Build();
+  // Create a DBus thread manager setter for its side effect.
+  (void) chromeos::DBusThreadManager::GetSetterForTesting();

[Chirantan Ekbote, 2014/09/12 00:52:16]

This is causing the build to fail on non-chrome os systems:

obj/chrome/browser/services/gcm/unit_tests.gcm_profile_service_unittest.o:../../chrome/browser/services/gcm/gcm_profile_service_unittest.cc:function
gcm::GCMProfileServiceTest::SetUp():error: undefined reference to
'chromeos::DBusThreadManager::GetSetterForTesting()'
obj/chrome/browser/services/gcm/unit_tests.gcm_profile_service_unittest.o:../../chrome/browser/services/gcm/gcm_profile_service_unittest.cc:function
gcm::GCMProfileServiceTest::SetUp():error: undefined reference to
'chromeos::DBusThreadManagerSetter::~DBusThreadManagerSetter()'


You could use an #if defined(OS_CHROMEOS) here or you could move the
ChromeOSGCMConnectionObserver into chrome/browser/chromeos/net and have it be
owned by ChromeBrowserMainPartsChromeos.  My preference is for the latter since
then you probably wouldn't need to init the DBusThreadManager here.

[Luigi Semenzato, 2014/09/12 01:24:21]

Thank you Chirantan.  I am tempted to use #ifdef OS_CHROMEOS instead of moving
that class one more time.

 }
 
 void GCMProfileServiceTest::TearDown() {
   gcm_profile_service_->driver()->RemoveAppHandler(kTestAppID);
 }
 
 void GCMProfileServiceTest::CreateGCMProfileService() {
   gcm_profile_service_ = static_cast<GCMProfileService*>(
       GCMProfileServiceFactory::GetInstance()->SetTestingFactoryAndUse(
           profile_.get(),
@@ skipping 129 matching lines @@
   GCMClient::OutgoingMessage message;
   message.id = "1";
   message.data["key1"] = "value1";
   SendAndWaitForCompletion( message);
 
   EXPECT_EQ(message.id, send_message_id());
   EXPECT_EQ(GCMClient::SUCCESS, send_result());
 }
 
 }  // namespace gcm