GCM: D-Bus methods for wake-on-packet

components/gcm_driver/default_gcm_app_handler.h

Index: components/gcm_driver/default_gcm_app_handler.h
diff --git a/components/gcm_driver/default_gcm_app_handler.h b/components/gcm_driver/default_gcm_app_handler.h
index 57613a54bada666684f9ac0c95a70b97c2fd295a..9c99e8395ca69d354013a3352662a2f806551dd8 100644
--- a/components/gcm_driver/default_gcm_app_handler.h
+++ b/components/gcm_driver/default_gcm_app_handler.h
@@ -30,6 +30,9 @@ class DefaultGCMAppHandler : public GCMAppHandler {
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DefaultGCMAppHandler);

[stevenjb, 2014/07/22 20:42:57]

This should be last.

+  static void NullCallback(const std::string& result);
+  static void ErrorCallback(const std::string& error_name,
+                            const std::string& error);

[stevenjb, 2014/07/22 20:42:57]

Do these need access to DefaultGCMAppHandler, or can the be file-local
functions? (Generally file-local would be preferred, we can always pass extra
data to these if wee need to using base::Bind)

[fgorski, 2014/07/23 20:18:03]

I agree. Also please add documentation why they are there.
I am not sure if you explained that someplace earlier or not. Why are you adding
CrOS specific wake on lan code to DefaultAppHandler?

 };
 
 }  // namespace gcm