GCM: D-Bus methods for wake-on-packet

components/gcm_driver/default_gcm_app_handler.h

 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_GCM_DRIVER_DEFAULT_GCM_APP_HANDLER_H_
 #define COMPONENTS_GCM_DRIVER_DEFAULT_GCM_APP_HANDLER_H_
 
 #include "base/compiler_specific.h"
 #include "components/gcm_driver/gcm_app_handler.h"
 
@@ skipping 11 matching lines @@
   virtual void OnMessage(const std::string& app_id,
                          const GCMClient::IncomingMessage& message) OVERRIDE;
   virtual void OnMessagesDeleted(const std::string& app_id) OVERRIDE;
   virtual void OnSendError(
       const std::string& app_id,
       const GCMClient::SendErrorDetails& send_error_details) OVERRIDE;
   virtual void OnConnected(const net::IPEndPoint& ip_endpoint) OVERRIDE;
   virtual void OnDisconnected() OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DefaultGCMAppHandler);

[stevenjb, 2014/07/22 20:42:57]

This should be last.

+  static void NullCallback(const std::string& result);
+  static void ErrorCallback(const std::string& error_name,
+                            const std::string& error);

[stevenjb, 2014/07/22 20:42:57]

Do these need access to DefaultGCMAppHandler, or can the be file-local
functions? (Generally file-local would be preferred, we can always pass extra
data to these if wee need to using base::Bind)

[fgorski, 2014/07/23 20:18:03]

I agree. Also please add documentation why they are there.
I am not sure if you explained that someplace earlier or not. Why are you adding
CrOS specific wake on lan code to DefaultAppHandler?

 };
 
 }  // namespace gcm
 
 #endif  // COMPONENTS_GCM_DRIVER_DEFAULT_GCM_APP_HANDLER_H_