Minor clarifications and simplifications.

Minor clarifications and simplifications as well as additional checks.

R=rossberg@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=22568

[rossberg, 2014-07-23 14:53:03]

https://codereview.chromium.org/409743004/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode71
src/types.h:71: //   UntaggedInt = UntaggedInt8 \/ UntaggedInt16 \/
UntaggedInt32)
Should include Int1 now. Also, spurious paren.

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode614
src/types.h:614: i::Handle<i::Map> map, TypeHandle bound, Region* region) {
While you're at it, can you also add assertions for bound? Here, for Constant,
and for Context? (using InherentLub)

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode682
src/types.h:682: ASSERT(SEMANTIC(bound->AsBitset() | BitsetType::kNumber)
Make this a proper subtype check for both axes, and use InherentLub.

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode746
src/types.h:746: ASSERT(SEMANTIC(bound->AsBitset()) ==
SEMANTIC(BitsetType::kArray));
Same here.

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode783
src/types.h:783: ASSERT(SEMANTIC(bound->AsBitset()) ==
SEMANTIC(BitsetType::kFunction));
And here.

[neis, 2014-07-23 15:17:19]

https://codereview.chromium.org/409743004/diff/1/src/types.h
File src/types.h (right):

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode71
src/types.h:71: //   UntaggedInt = UntaggedInt8 \/ UntaggedInt16 \/
UntaggedInt32)
On 2014/07/23 14:53:03, rossberg wrote:
> Should include Int1 now. Also, spurious paren.

Done.

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode614
src/types.h:614: i::Handle<i::Map> map, TypeHandle bound, Region* region) {
On 2014/07/23 14:53:03, rossberg wrote:
> While you're at it, can you also add assertions for bound? Here, for Constant,
> and for Context? (using InherentLub)

Done.

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode682
src/types.h:682: ASSERT(SEMANTIC(bound->AsBitset() | BitsetType::kNumber)
On 2014/07/23 14:53:03, rossberg wrote:
> Make this a proper subtype check for both axes, and use InherentLub.

Done.

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode746
src/types.h:746: ASSERT(SEMANTIC(bound->AsBitset()) ==
SEMANTIC(BitsetType::kArray));
On 2014/07/23 14:53:03, rossberg wrote:
> Same here.

Done.

https://codereview.chromium.org/409743004/diff/1/src/types.h#newcode783
src/types.h:783: ASSERT(SEMANTIC(bound->AsBitset()) ==
SEMANTIC(BitsetType::kFunction));
On 2014/07/23 14:53:03, rossberg wrote:
> And here.

Done.

[neis, 2014-07-23 15:17:42]

The CQ bit was checked by neis@chromium.org

[neis, 2014-07-23 15:17:42]

The CQ bit was unchecked by neis@chromium.org

[rossberg, 2014-07-23 15:24:40]

lgtm

[neis, 2014-07-23 15:30:41]

Committed patchset #2 manually as r22568 (presubmit successful).