Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 40973002: Enable reference adoption checks for Blink+skia in Debug builds. (Closed)

Created:
7 years, 2 months ago by bungeman-skia
Modified:
7 years, 2 months ago
Reviewers:
Justin Novosad, reed1
CC:
chromium-reviews
Visibility:
Public.

Description

Enable reference adoption checks for Blink+skia in Debug builds. This is an alternate to Issue 29763002. R=junov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230831

Patch Set 1 #

Patch Set 2 : Patching on gpu bots is basically broken, use rietveld for arbitrary patches. #

Total comments: 1

Patch Set 3 : Unfix spelling for now. #

Patch Set 4 : Just the Chromium changes for sanity. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +6 lines, -0 lines 0 comments Download
A skia/config/sk_ref_cnt_ext_debug.h View 1 chunk +48 lines, -0 lines 0 comments Download
A skia/config/sk_ref_cnt_ext_release.h View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bungeman-skia
This is the Chromium side of https://codereview.chromium.org/40503002/ . This would go in as part of ...
7 years, 2 months ago (2013-10-24 18:02:06 UTC) #1
Justin Novosad
Whoa, how did you upload a CL that has changes to chromium and skia?
7 years, 2 months ago (2013-10-24 18:24:53 UTC) #2
Justin Novosad
Yep, I like this better than what I had. lgtm https://codereview.chromium.org/40973002/diff/80001/skia/config/sk_ref_cnt_ext_debug.h File skia/config/sk_ref_cnt_ext_debug.h (right): https://codereview.chromium.org/40973002/diff/80001/skia/config/sk_ref_cnt_ext_debug.h#newcode19 ...
7 years, 2 months ago (2013-10-24 18:28:51 UTC) #3
bungeman-skia
On 2013/10/24 18:24:53, junov wrote: > Whoa, how did you upload a CL that has ...
7 years, 2 months ago (2013-10-24 18:30:03 UTC) #4
bungeman-skia
and... I'll get my not-yet-fixed-spelling version up in a second.
7 years, 2 months ago (2013-10-24 18:33:20 UTC) #5
Justin Novosad
Just checking: there is no way the CQ will ever process this intelligently, right?
7 years, 2 months ago (2013-10-24 18:43:22 UTC) #6
bungeman-skia
On 2013/10/24 18:43:22, junov wrote: > Just checking: there is no way the CQ will ...
7 years, 2 months ago (2013-10-24 18:54:23 UTC) #7
bungeman-skia
7 years, 2 months ago (2013-10-24 21:58:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r230831 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698