Enable reference adoption checks for Blink+skia in Debug builds.

Enable reference adoption checks for Blink+skia in Debug builds.

This is an alternate to Issue 29763002.

R=junov@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230831

[bungeman-skia, 2013-10-24 18:02:06]

This is the Chromium side of https://codereview.chromium.org/40503002/ . This
would go in as part of the next Skia roll after that change landed.

[Justin Novosad, 2013-10-24 18:24:53]

Whoa, how did you upload a CL that has changes to chromium and skia?

[Justin Novosad, 2013-10-24 18:28:51]

Yep, I like this better than what I had.

lgtm

https://codereview.chromium.org/40973002/diff/80001/skia/config/sk_ref_cnt_ex...
File skia/config/sk_ref_cnt_ext_debug.h (right):

https://codereview.chromium.org/40973002/diff/80001/skia/config/sk_ref_cnt_ex...
skia/config/sk_ref_cnt_ext_debug.h:19: void deref() const {
SkRefCntBase::unref(); }
So you moved the deref->unref alias into this shim. Neat.

[bungeman-skia, 2013-10-24 18:30:03]

On 2013/10/24 18:24:53, junov wrote:
> Whoa, how did you upload a CL that has changes to chromium and skia?

It's all patches... all the way down. Most bots I just use something like

~/depot_tools/trychange.py --email=example@chromium.org --name=skia_ref
--rietveld_url=codereview.chromium.org --issue=40973002 --patchset=1
--file=skia/config/SkUserConfig.h --file=skia/config/sk_ref_cnt_ext_release.h
--file=skia/config/sk_ref_cnt_ext_debug.h
--file=third_party/skia/include/core/SkRefCnt.h
--file=third_party/skia/src/core/SkRefCnt.cpp --revision=230724 --bot=linux_rel

which is what I did the first time, and this works with most bots. But the blink
and gpu bots apparently don't look at the svn repo anymore (I have my  opinions
about the over dependence on rietveld for the bots) and instead just pick up the
patch from rietveld. So this time around I just manually edited the gcl metadata
to put the skia files on the CL list. I also have a hacked upload.py I can use
to force my own arbitrary diffs to be uploaded when that doesn't work. Note that
you can't commit it like this, but it provides a place for the bots to pick up a
patch.

[bungeman-skia, 2013-10-24 18:33:20]

and... I'll get my not-yet-fixed-spelling version up in a second.

[Justin Novosad, 2013-10-24 18:43:22]

Just checking: there is no way the CQ will ever process this intelligently,
right?

[bungeman-skia, 2013-10-24 18:54:23]

On 2013/10/24 18:43:22, junov wrote:
> Just checking: there is no way the CQ will ever process this intelligently,
> right?

Ummmm... it might. Skia would subsequently fail to checkout/update. Oh,
intelligently... no.

[bungeman-skia, 2013-10-24 21:58:03]

Committed patchset #4 manually as r230831 (presubmit successful).