Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 409613002: Store both major and minor key on code stubs. (Closed)

Created:
6 years, 5 months ago by Yang
Modified:
6 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Store both major and minor key on code stubs. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22505

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -132 lines) Patch
M src/code-stubs.h View 6 chunks +13 lines, -23 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/debug.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 chunk +2 lines, -2 lines 1 comment Download
M src/ic.h View 1 chunk +3 lines, -6 lines 0 comments Download
M src/ic.cc View 3 chunks +9 lines, -13 lines 0 comments Download
M src/liveedit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 4 chunks +8 lines, -16 lines 1 comment Download
M src/objects.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 4 chunks +16 lines, -47 lines 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 5 months ago (2014-07-21 12:04:01 UTC) #1
Jakob Kummerow
LGTM. Nice unification! https://codereview.chromium.org/409613002/diff/1/src/heap-snapshot-generator.cc File src/heap-snapshot-generator.cc (right): https://codereview.chromium.org/409613002/diff/1/src/heap-snapshot-generator.cc#newcode1502 src/heap-snapshot-generator.cc:1502: "(%s code)", CodeStub::MajorName( nit: consider pulling ...
6 years, 5 months ago (2014-07-21 12:23:19 UTC) #2
Yang
6 years, 5 months ago (2014-07-21 13:10:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22505 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698