Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 409563004: Fix gesture debugging (Closed)

Created:
6 years, 5 months ago by jdduke (slow)
Modified:
6 years, 5 months ago
Reviewers:
tdresser
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix gesture debugging Improved gesture output. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284685

Patch Set 1 #

Patch Set 2 : Actually add the changes... #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -133 lines) Patch
M ui/android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java View 1 2 chunks +0 lines, -9 lines 0 comments Download
M ui/events/gesture_detection/gesture_config_helper_android.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
M ui/events/gesture_detection/gesture_provider_unittest.cc View 1 3 chunks +17 lines, -89 lines 1 comment Download
M ui/events/gesture_detection/scale_gesture_detector.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M ui/events/gesture_detection/scale_gesture_detector.cc View 1 6 chunks +6 lines, -9 lines 0 comments Download
M ui/events/gestures/gesture_configuration.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/android/view_configuration.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/android/view_configuration.cc View 1 4 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jdduke (slow)
PTAL, thanks.
6 years, 5 months ago (2014-07-21 21:19:12 UTC) #1
tdresser
On 2014/07/21 21:19:12, jdduke wrote: > PTAL, thanks. LGTM...
6 years, 5 months ago (2014-07-21 21:22:45 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 5 months ago (2014-07-21 21:27:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/409563004/1
6 years, 5 months ago (2014-07-21 21:27:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 23:26:01 UTC) #5
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 5 months ago (2014-07-21 23:43:43 UTC) #6
jdduke (slow)
On 2014/07/21 21:22:45, tdresser wrote: > On 2014/07/21 21:19:12, jdduke wrote: > > PTAL, thanks. ...
6 years, 5 months ago (2014-07-22 00:02:09 UTC) #7
tdresser
https://codereview.chromium.org/409563004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/409563004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode1568 ui/events/gesture_detection/gesture_provider_unittest.cc:1568: TEST_F(GestureProviderTest, NoPinchZoomWithFatFinger) { What's making this test pass? Is ...
6 years, 5 months ago (2014-07-22 12:10:40 UTC) #8
tdresser
On 2014/07/22 12:10:40, tdresser wrote: > https://codereview.chromium.org/409563004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc > File ui/events/gesture_detection/gesture_provider_unittest.cc (right): > > https://codereview.chromium.org/409563004/diff/20001/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode1568 > ...
6 years, 5 months ago (2014-07-22 14:51:35 UTC) #9
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 5 months ago (2014-07-22 14:52:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/409563004/20001
6 years, 5 months ago (2014-07-22 14:53:58 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 15:55:35 UTC) #12
Message was sent while issue was closed. 
Change committed as 284685

Powered by Google App Engine
This is Rietveld 408576698