Fix gesture debugging

ui/events/gesture_detection/gesture_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/time/time.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 246 matching lines @@
     config.min_gesture_bounds_length = min_gesture_bound_length;
     SetUpWithConfig(config);
   }
 
   void SetMaxGestureBoundsLength(float max_gesture_bound_length) {
     GestureProvider::Config config = GetDefaultConfig();
     config.max_gesture_bounds_length = max_gesture_bound_length;
     SetUpWithConfig(config);
   }
 
-  void EnableTouchMajorUseInScaling() {
-    GestureProvider::Config config = GetDefaultConfig();
-    config.scale_gesture_detector_config.use_touch_major_in_span = true;
-    SetUpWithConfig(config);
-  }
-
   bool HasDownEvent() const { return gesture_provider_->current_down_event(); }
 
  protected:
   void CheckScrollEventSequenceForEndActionType(
       MotionEvent::Action end_action_type) {
     base::TimeTicks event_time = base::TimeTicks::Now();
     const float scroll_to_x = kFakeCoordX + 100;
     const float scroll_to_y = kFakeCoordY + 100;
     int motion_event_id = 0;
 
@@ skipping 1279 matching lines @@
   gesture_provider_->OnTouchEvent(event);
   EXPECT_EQ(ET_GESTURE_SCROLL_END, GetMostRecentGestureEventType());
   EXPECT_EQ(1, GetMostRecentGestureEvent().details.touch_points());
   EXPECT_EQ(gfx::RectF(kFakeCoordX - kMockTouchRadius,
                        kFakeCoordY - kMockTouchRadius,
                        kMockTouchRadius * 2,
                        kMockTouchRadius * 2),
             GetMostRecentGestureEvent().details.bounding_box());
 }
 
-// Verify that pinch zoom that uses touch major values sends the proper event
-// sequence.
-TEST_F(GestureProviderTest, PinchZoomWithTouchMajor) {
-  EnableTouchMajorUseInScaling();
-
-  base::TimeTicks event_time = base::TimeTicks::Now();
-  const float touch_slop = GetTouchSlop();
-  gesture_provider_->SetMultiTouchZoomSupportEnabled(true);
-
-  int secondary_coord_x = kFakeCoordX + 20 * touch_slop;
-  int secondary_coord_y = kFakeCoordY + 20 * touch_slop;
-
-  MockMotionEvent event =
-      ObtainMotionEvent(event_time, MotionEvent::ACTION_DOWN);
-  EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
-  EXPECT_EQ(ET_GESTURE_TAP_DOWN, GetMostRecentGestureEventType());
-
-  event = ObtainMotionEvent(event_time,
-                            MotionEvent::ACTION_POINTER_DOWN,
-                            kFakeCoordX,
-                            kFakeCoordY,
-                            secondary_coord_x,
-                            secondary_coord_y);
-
-  gesture_provider_->OnTouchEvent(event);
-  EXPECT_EQ(1U, GetReceivedGestureCount());
-
-  secondary_coord_x += 5 * touch_slop;
-  secondary_coord_y += 5 * touch_slop;
-  event = ObtainMotionEvent(event_time,
-                            MotionEvent::ACTION_MOVE,
-                            kFakeCoordX,
-                            kFakeCoordY,
-                            secondary_coord_x,
-                            secondary_coord_y);
-  EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
-  EXPECT_EQ(2, GetMostRecentGestureEvent().details.touch_points());
-  EXPECT_TRUE(HasReceivedGesture(ET_GESTURE_PINCH_BEGIN));
-  EXPECT_TRUE(HasReceivedGesture(ET_GESTURE_SCROLL_BEGIN));
-  EXPECT_TRUE(HasReceivedGesture(ET_GESTURE_SCROLL_UPDATE));
-
-  secondary_coord_x += 2 * touch_slop;
-  secondary_coord_y += 2 * touch_slop;
-  event = ObtainMotionEvent(event_time,
-                            MotionEvent::ACTION_MOVE,
-                            kFakeCoordX,
-                            kFakeCoordY,
-                            secondary_coord_x,
-                            secondary_coord_y);
-  EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
-  EXPECT_EQ(ET_GESTURE_PINCH_UPDATE, GetMostRecentGestureEventType());
-  EXPECT_LT(1.f, GetMostRecentGestureEvent().details.scale());
-
-  secondary_coord_x -= 2 * touch_slop;
-  secondary_coord_y -= 2 * touch_slop;
-  event = ObtainMotionEvent(event_time,
-                            MotionEvent::ACTION_MOVE,
-                            kFakeCoordX,
-                            kFakeCoordY,
-                            secondary_coord_x,
-                            secondary_coord_y);
-  EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
-  EXPECT_EQ(ET_GESTURE_PINCH_UPDATE, GetMostRecentGestureEventType());
-  EXPECT_GT(1.f, GetMostRecentGestureEvent().details.scale());
-
-  event = ObtainMotionEvent(event_time,
-                            MotionEvent::ACTION_POINTER_UP,
-                            kFakeCoordX,
-                            kFakeCoordY,
-                            secondary_coord_x,
-                            secondary_coord_y);
-  EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
-  EXPECT_EQ(ET_GESTURE_PINCH_END, GetMostRecentGestureEventType());
-  EXPECT_FALSE(HasReceivedGesture(ET_GESTURE_SCROLL_END));
-
-  event = ObtainMotionEvent(event_time, MotionEvent::ACTION_UP);
-  gesture_provider_->OnTouchEvent(event);
-  EXPECT_EQ(ET_GESTURE_SCROLL_END, GetMostRecentGestureEventType());
-}
-
 // Verify that no accidental pinching occurs if the touch size is large relative
 // to the min scaling span when the touch major value is used in scaling.
-TEST_F(GestureProviderTest, NoPinchZoomWithTouchMajorAndFatFinger) {
-  EnableTouchMajorUseInScaling();
-
+TEST_F(GestureProviderTest, NoPinchZoomWithFatFinger) {

[tdresser, 2014/07/22 12:10:40]

What's making this test pass? Is it just the increase to min_scaling_span?

   base::TimeTicks event_time = base::TimeTicks::Now();
   const float kFatFingerSize = GetMinScalingSpan() * 3.f;
 
   gesture_provider_->SetDoubleTapSupportForPlatformEnabled(false);
   gesture_provider_->SetMultiTouchZoomSupportEnabled(true);
 
   MockMotionEvent event =
       ObtainMotionEvent(event_time, MotionEvent::ACTION_DOWN);
   EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
   EXPECT_EQ(ET_GESTURE_TAP_DOWN, GetMostRecentGestureEventType());
@@ skipping 17 matching lines @@
                             MotionEvent::ACTION_MOVE);
   event.SetTouchMajor(kFatFingerSize * 3.5f);
   EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
   EXPECT_EQ(1U, GetReceivedGestureCount());
 
   event = ObtainMotionEvent(event_time + kOneSecond * 4,
                             MotionEvent::ACTION_MOVE);
   event.SetTouchMajor(kFatFingerSize * 5.f);
   EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
   EXPECT_EQ(1U, GetReceivedGestureCount());
+
+  event = ObtainMotionEvent(event_time + kOneSecond * 4,
+                            MotionEvent::ACTION_MOVE,
+                            kFakeCoordX + 50.f,
+                            kFakeCoordY - 25.f);
+  event.SetTouchMajor(kFatFingerSize * 10.f);
+  EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
+  EXPECT_FALSE(HasReceivedGesture(ET_GESTURE_PINCH_BEGIN));
+
+  event = ObtainMotionEvent(event_time + kOneSecond * 4,
+                            MotionEvent::ACTION_MOVE,
+                            kFakeCoordX + 100.f,
+                            kFakeCoordY - 50.f);
+  event.SetTouchMajor(kFatFingerSize * 5.f);
+  EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
+  EXPECT_FALSE(HasReceivedGesture(ET_GESTURE_PINCH_BEGIN));
 }
 
 // Verify that multi-finger swipe sends the proper event sequence.
 TEST_F(GestureProviderTest, MultiFingerSwipe) {
   EnableSwipe();
   gesture_provider_->SetMultiTouchZoomSupportEnabled(false);
   const float min_swipe_velocity = GetMinSwipeVelocity();
 
   // One finger - swipe right
   OneFingerSwipe(2 * min_swipe_velocity, 0);
@@ skipping 706 matching lines @@
       ObtainMotionEvent(event_time + kOneMicrosecond, MotionEvent::ACTION_UP);
   EXPECT_TRUE(gesture_provider_->OnTouchEvent(event));
   EXPECT_EQ(ET_GESTURE_TAP, GetMostRecentGestureEventType());
   EXPECT_EQ(kMaxGestureBoundsLength,
             GetMostRecentGestureEvent().details.bounding_box_f().width());
   EXPECT_EQ(kMaxGestureBoundsLength,
             GetMostRecentGestureEvent().details.bounding_box_f().height());
 }
 
 }  // namespace ui