Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 409563002: Set PPAPI plugins' requests' contexts to 'WebURLRequest::RequestContextPlugin'. (Closed)

Created:
6 years, 5 months ago by Mike West
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Set PPAPI plugins' requests' contexts to 'WebURLRequest::RequestContextPlugin'. Pepper plugins' requests are piped through Blink's Fetch implementation, giving us the opportunity to make policy decisions about whether or not they should be allowed by CSP or Mixed Content (we're currently not using this ability). In order to make these decisions, we need to know that the request is for data a plugin is requesting, as opposed to a plugin itself. This patch adds that detail to PPAPI's URL-requesting logic. BUG=390497 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/renderer/pepper/pepper_url_loader_host.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike West
Mind taking a look at this, Jochen? -mike
6 years, 5 months ago (2014-07-21 08:28:42 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-21 11:29:32 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 5 months ago (2014-07-21 11:45:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/409563002/1
6 years, 5 months ago (2014-07-21 11:46:47 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 15:04:28 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 16:46:42 UTC) #6
Message was sent while issue was closed.
Change committed as 284445

Powered by Google App Engine
This is Rietveld 408576698