Issue 409543008: Revert 284508 "GN chrome/common build, rename enable_printing."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409543008: Revert 284508 "GN chrome/common build, rename enable_printing." (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 284508 "GN chrome/common build, rename enable_printing." > GN chrome/common build, rename enable_printing. > > This adds the missing conditions to the chrome/common GN build file (previously > only the basic files were there). Some refactoring of the GYP file to make this > possible. > > Renames the enable_printing flag to printing_mode since this is an integer > tri-state. > > Minor improvements to chrome/renderer > > R=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/400243003 TBR=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284517

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -211 lines)			Patch
M	trunk/src/build/config/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/build/config/features.gni	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/build/secondary/tools/grit/grit_rule.gni	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/BUILD.gn	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/chrome_common.gypi	View	11 chunks	+63 lines, -63 lines	0 comments	Download
M	trunk/src/chrome/common/BUILD.gn	View	4 chunks	+7 lines, -126 lines	0 comments	Download
M	trunk/src/chrome/renderer/BUILD.gn	View	3 chunks	+12 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/utility/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/content/browser/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/src/skia/BUILD.gn	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 5 months ago (2014-07-21 22:20:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r284517 (tree was closed).

Expand Messages | Collapse Messages