Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: trunk/src/chrome/renderer/BUILD.gn

Issue 409543008: Revert 284508 "GN chrome/common build, rename enable_printing." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/common/BUILD.gn ('k') | trunk/src/chrome/utility/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/renderer/BUILD.gn
===================================================================
--- trunk/src/chrome/renderer/BUILD.gn (revision 284516)
+++ trunk/src/chrome/renderer/BUILD.gn (working copy)
@@ -30,13 +30,10 @@
"//chrome:strings",
"//components/autofill/content/renderer",
"//components/data_reduction_proxy/common",
- "//components/plugins/renderer",
- "//components/startup_metric_utils",
"//components/translate/core/common",
"//components/translate/core/language_detection",
"//components/visitedlink/renderer",
"//content/public/renderer",
- "//extensions:extensions_resources",
"//media/cast/logging/proto",
"//third_party/re2",
"//net",
@@ -51,7 +48,10 @@
"//webkit/common",
"//webkit:resources",
#"../components/components.gyp:cdm_renderer", TODO(GYP)
+ #"../components/components.gyp:startup_metric_utils", TODO(GYP)
+ #"../components/components.gyp:plugins_renderer", TODO(GYP)
#"../extensions/extensions.gyp:extensions_renderer", TODO(GYP)
+ #"../extensions/extensions_resources.gyp:extensions_resources", TODO(GYP)
#"../media/cast/cast.gyp:cast_sender", TODO(GYP)
#"../media/cast/cast.gyp:cast_transport", TODO(GYP)
]
@@ -108,12 +108,17 @@
if (enable_spellcheck) {
sources += rebase_path(gypi_values.chrome_renderer_spellchecker_sources,
".", "..")
- deps += [ "//third_party/hunspell" ]
+ # TODO(GYP) When hunspell is done, the extra defines can be removed.
+ #deps += [ "//third_party/hunspell" ]
+ defines += [ "HUNSPELL_STATIC", "HUNSPELL_CHROME_CLIENT", "OPENOFFICEORG" ]
+
}
- if (printing_mode > 0) {
- deps += [ "//printing" ]
- if (printing_mode == 1) {
+ if (enable_printing > 0) {
+ deps += [
+ #"//printing", TODO(GYP)
+ ]
+ if (enable_printing == 1) {
sources += rebase_path(gypi_values.chrome_renderer_printing_sources,
".", "..")
}
« no previous file with comments | « trunk/src/chrome/common/BUILD.gn ('k') | trunk/src/chrome/utility/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698