Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 409403003: [MIPS] Add seccomp bpf support (Closed)

Created:
6 years, 5 months ago by nedeljko
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, agl, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[MIPS] Add seccomp bpf support Add support for seccomp bpf sandboxing on MIPS architecture. Enable testing of seccomp bpf sandbox. Support for seccomp bpf for MIPS was added in Linux kernel version 3.15. This patchset was reviewed in https://chromiumcodereview.appspot.com/260793003/ and re-created to workaround a commit-queue issue. BUG=369594 TEST=sandbox_linux_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285538

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix for Android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1918 lines, -86 lines) Patch
M build/common.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/loader/sandbox_linux/nacl_bpf_sandbox_linux.cc View 4 chunks +3 lines, -5 lines 0 comments Download
M content/common/sandbox_linux/bpf_gpu_policy_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/bpf_renderer_policy_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/sandbox_linux/sandbox_seccomp_bpf_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/sandbox_linux.gypi View 1 2 chunks +4 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.cc View 6 chunks +12 lines, -6 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/sigsys_handlers.cc View 3 chunks +27 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions.cc View 4 chunks +13 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.h View 3 chunks +7 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_sets.cc View 33 chunks +76 lines, -49 lines 0 comments Download
M sandbox/linux/seccomp-bpf/errorcode.h View 1 chunk +5 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/linux_seccomp.h View 4 chunks +67 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.h View 1 2 3 chunks +26 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall.cc View 4 chunks +104 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_iterator.cc View 1 chunk +12 lines, -1 line 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_iterator_unittest.cc View 4 chunks +43 lines, -3 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M sandbox/linux/seccomp-bpf/trap.cc View 4 chunks +31 lines, -5 lines 0 comments Download
A sandbox/linux/services/android_mips_ucontext.h View 1 chunk +51 lines, -0 lines 0 comments Download
M sandbox/linux/services/android_ucontext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sandbox/linux/services/linux_syscalls.h View 1 chunk +4 lines, -0 lines 0 comments Download
A sandbox/linux/services/mips_linux_syscalls.h View 1 chunk +1412 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
nedeljko
This issue was created as a workaround for a problem with base URL in issue ...
6 years, 5 months ago (2014-07-23 12:06:58 UTC) #1
nedeljko
Please have a look. Thanks.
6 years, 5 months ago (2014-07-23 12:36:25 UTC) #2
jln (very slow on Chromium)
lgtm based on the previous reviews at https://chromiumcodereview.appspot.com/260793003/ I changed your commit message to include ...
6 years, 5 months ago (2014-07-23 19:09:24 UTC) #3
jln (very slow on Chromium)
The CQ bit was checked by jln@chromium.org
6 years, 5 months ago (2014-07-23 19:09:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nedeljko.babic@imgtec.com/409403003/20001
6 years, 5 months ago (2014-07-23 19:11:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 22:22:16 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 22:29:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/163864) android_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/209861)
6 years, 5 months ago (2014-07-23 22:29:56 UTC) #8
nedeljko
I had a problem with Android and this Patch Set solves it. I will commit ...
6 years, 5 months ago (2014-07-24 13:33:32 UTC) #9
jln (very slow on Chromium)
On 2014/07/24 13:33:32, nedeljko wrote: > I had a problem with Android and this Patch ...
6 years, 5 months ago (2014-07-24 17:19:42 UTC) #10
nedeljko
The CQ bit was checked by nedeljko.babic@imgtec.com
6 years, 5 months ago (2014-07-24 20:09:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nedeljko.babic@imgtec.com/409403003/40001
6 years, 5 months ago (2014-07-24 20:13:45 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 23:52:24 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 00:29:23 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2209)
6 years, 5 months ago (2014-07-25 00:29:24 UTC) #15
nedeljko
The CQ bit was checked by nedeljko.babic@imgtec.com
6 years, 5 months ago (2014-07-25 08:28:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nedeljko.babic@imgtec.com/409403003/40001
6 years, 5 months ago (2014-07-25 08:30:12 UTC) #17
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 09:03:48 UTC) #18
Message was sent while issue was closed.
Change committed as 285538

Powered by Google App Engine
This is Rietveld 408576698