Issue 409223003: Revert of Simplify the logic in DesktopWindowTreeHostX11 for FocusOut

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409223003: Revert of Simplify the logic in DesktopWindowTreeHostX11 for FocusOut (Closed)

Created:
6 years, 5 months ago by pkotwicz

Modified:
6 years, 5 months ago

Reviewers:
Elliot Glaysher, sadrul, erg

CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, tfarina, kalyank, ben+aura_chromium.org, ben+views_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of Simplify the logic in DesktopWindowTreeHostX11 for FocusOut (https://codereview.chromium.org/379773003/) Reason for revert: I am reverting this CL because it causes regressions like crbug.com/395985. This CL is in the right direction, but I need to make the capture code for tab dragging less crazy first. See comment #3 in crbug.com/395985 for more details Original issue's description: > Simplify the logic in DesktopWindowTreeHostX11 for FocusOut > > We should have the same handling regardless of whether the 'mode' member is > NotifyGrab or NotifyUngrab. According to > http://tronche.com/gui/x/xlib/events/input-focus/grab.html, whether the mode > field is NotifyGrab or NotifyUngrab depends on whether there is a new > capturer for the keyboard. The X window has lost keyboard capture in both cases. > > BUG=392480 > TEST=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283823 TBR=erg@chromium.org,erg@google.com,sadrul@chromium.org NOTREECHECKS=true NOTRY=true BUG=392480 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284919

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -3 lines)			Patch
M	ui/aura/window_event_dispatcher.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/window_event_dispatcher.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/aura/window_tree_host_x11.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

pkotwicz

Created Revert of Simplify the logic in DesktopWindowTreeHostX11 for FocusOut

6 years, 5 months ago (2014-07-23 14:04:50 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/409223003/1

6 years, 5 months ago (2014-07-23 14:10:06 UTC) #2

Message was sent while issue was closed.

Change committed as 284919