Issue 409133002: GuestView: Lazy registration and once for all profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 409133002: GuestView: Lazy registration and once for all profiles (Closed)

Created:
6 years, 5 months ago by Fady Samuel

Modified:
6 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

GuestView: Lazy registration and once for all profiles GuestViews are registered and re-registered on a per-profile basis. This would cause a DCHECK to fire. Make registration lazy and once on first GuestView creation. BUG=none TBR=fsamuel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284723

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -9 lines)			Patch
M	chrome/browser/guest_view/guest_view_base.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/guest_view/guest_view_base.cc	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/guest_view/guest_view_manager.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/409133002/1

6 years, 5 months ago (2014-07-22 14:35:53 UTC) #2

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 5 months ago (2014-07-22 16:30:16 UTC) #3

Message was sent while issue was closed.

Change committed as 284723