Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 409133002: GuestView: Lazy registration and once for all profiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.h ('k') | chrome/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/guest_view/guest_view_base.cc
diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc
index 402ee2b6db5cf0555d95303a386d44d905685734..e9b5ebaa22d5f84fab50a5b85dcafebd298304dd 100644
--- a/chrome/browser/guest_view/guest_view_base.cc
+++ b/chrome/browser/guest_view/guest_view_base.cc
@@ -143,12 +143,6 @@ void GuestViewBase::InitWithWebContents(
}
// static
-void GuestViewBase::RegisterGuestViewTypes() {
- GuestView<WebViewGuest>::Register();
- GuestView<AppViewGuest>::Register();
-}
-
-// static
void GuestViewBase::RegisterGuestViewType(
const std::string& view_type,
const GuestCreationCallback& callback) {
@@ -163,6 +157,9 @@ GuestViewBase* GuestViewBase::Create(
content::BrowserContext* browser_context,
int guest_instance_id,
const std::string& view_type) {
+ if (guest_view_registry.Get().empty())
+ RegisterGuestViewTypes();
+
GuestViewCreationMap::iterator it =
guest_view_registry.Get().find(view_type);
if (it == guest_view_registry.Get().end()) {
@@ -386,3 +383,9 @@ void GuestViewBase::CompleteInit(const std::string& embedder_extension_id,
guest_web_contents);
callback.Run(guest_web_contents);
}
+
+// static
+void GuestViewBase::RegisterGuestViewTypes() {
+ AppViewGuest::Register();
+ WebViewGuest::Register();
+}
« no previous file with comments | « chrome/browser/guest_view/guest_view_base.h ('k') | chrome/browser/guest_view/guest_view_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698