Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 409113002: Refactoring: get rid of notificataions in ParallelAuthenticator (Closed)

Created:
6 years, 5 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 4 months ago
Reviewers:
stevenjb, Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Refactoring: get rid of notificataions in ParallelAuthenticator BUG=387613 R=nkostylev@chromium.org TBR=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291045

Patch Set 1 #

Total comments: 6

Patch Set 2 : Merge w/ToT again #

Patch Set 3 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -79 lines) Patch
M chrome/browser/chrome_notification_types.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.h View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.cc View 1 3 chunks +9 lines, -13 lines 0 comments Download
D chrome/browser/chromeos/login/auth/authentication_notification_details.h View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.cc View 1 10 chunks +9 lines, -32 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/login_event_recorder.h View 1 2 2 chunks +16 lines, -0 lines 0 comments Download
M chromeos/login_event_recorder.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Denis Kuznetsov (DE-MUC)
Nikita as reviewer, Steven as chromeos/ owner.
6 years, 5 months ago (2014-07-22 13:59:04 UTC) #1
Nikita (slow)
lgtm https://chromiumcodereview.appspot.com/409113002/diff/1/chrome/browser/chromeos/boot_times_loader.h File chrome/browser/chromeos/boot_times_loader.h (right): https://chromiumcodereview.appspot.com/409113002/diff/1/chrome/browser/chromeos/boot_times_loader.h#newcode45 chrome/browser/chromeos/boot_times_loader.h:45: // Add a time marker for login. A ...
6 years, 5 months ago (2014-07-22 15:50:26 UTC) #2
stevenjb
lgtm https://chromiumcodereview.appspot.com/409113002/diff/1/chrome/browser/chromeos/boot_times_loader.h File chrome/browser/chromeos/boot_times_loader.h (right): https://chromiumcodereview.appspot.com/409113002/diff/1/chrome/browser/chromeos/boot_times_loader.h#newcode52 chrome/browser/chromeos/boot_times_loader.h:52: virtual void RecordAuthenticationSuccess() OVERRIDE; nit: WS
6 years, 5 months ago (2014-07-22 16:11:04 UTC) #3
Denis Kuznetsov (DE-MUC)
https://chromiumcodereview.appspot.com/409113002/diff/1/chrome/browser/chromeos/boot_times_loader.h File chrome/browser/chromeos/boot_times_loader.h (right): https://chromiumcodereview.appspot.com/409113002/diff/1/chrome/browser/chromeos/boot_times_loader.h#newcode45 chrome/browser/chromeos/boot_times_loader.h:45: // Add a time marker for login. A timeline ...
6 years, 4 months ago (2014-08-20 13:50:19 UTC) #4
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 4 months ago (2014-08-20 13:50:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/409113002/40001
6 years, 4 months ago (2014-08-20 13:51:18 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-20 15:04:23 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 16:37:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/1098)
6 years, 4 months ago (2014-08-20 16:37:24 UTC) #9
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 4 months ago (2014-08-21 10:41:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/409113002/40001
6 years, 4 months ago (2014-08-21 10:43:37 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 11:24:54 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 291045

Powered by Google App Engine
This is Rietveld 408576698