Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: chromeos/login_event_recorder.h

Issue 409113002: Refactoring: get rid of notificataions in ParallelAuthenticator (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser_chromeos.gypi ('k') | chromeos/login_event_recorder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/login_event_recorder.h
diff --git a/chromeos/login_event_recorder.h b/chromeos/login_event_recorder.h
index ec695b4d9359ce03908ba9b2e5f1cb3366fea1e7..f4d0f8b072916217e089901a3dc78b4d4f649d8f 100644
--- a/chromeos/login_event_recorder.h
+++ b/chromeos/login_event_recorder.h
@@ -18,8 +18,18 @@ class CHROMEOS_EXPORT LoginEventRecorder {
public:
class Delegate {
public:
+ // Add a time marker for login. A timeline will be dumped to
+ // /tmp/login-times-sent after login is done. If |send_to_uma| is true
+ // the time between this marker and the last will be sent to UMA with
+ // the identifier BootTime.|marker_name|.
virtual void AddLoginTimeMarker(const std::string& marker_name,
bool send_to_uma) = 0;
+
+ // Record events for successful authentication.
+ virtual void RecordAuthenticationSuccess() = 0;
+
+ // Record events for authentication failure.
+ virtual void RecordAuthenticationFailure() = 0;
};
LoginEventRecorder();
virtual ~LoginEventRecorder();
@@ -34,6 +44,12 @@ class CHROMEOS_EXPORT LoginEventRecorder {
// the identifier BootTime.|marker_name|.
void AddLoginTimeMarker(const std::string& marker_name, bool send_to_uma);
+ // Record events for successful authentication.
+ void RecordAuthenticationSuccess();
+
+ // Record events for authentication failure.
+ void RecordAuthenticationFailure();
+
private:
Delegate* delegate_;
« no previous file with comments | « chrome/chrome_browser_chromeos.gypi ('k') | chromeos/login_event_recorder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698