Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: tools/telemetry/telemetry/value/summary.py

Issue 409023002: Add SkipValue to Telemetry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ned's comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/skip_unittest.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/summary.py
diff --git a/tools/telemetry/telemetry/value/summary.py b/tools/telemetry/telemetry/value/summary.py
index a715517ad46dbf9c3b90cf51dbdff22753607ba4..738f14811ae564838d23894f24eb38ef4c96cc7f 100644
--- a/tools/telemetry/telemetry/value/summary.py
+++ b/tools/telemetry/telemetry/value/summary.py
@@ -6,6 +6,7 @@ from collections import defaultdict
from telemetry.value import failure
from telemetry.value import merge_values
+from telemetry.value import skip
class Summary(object):
"""Computes summary values from the per-page-run values produced by a test.
@@ -60,8 +61,8 @@ class Summary(object):
def _ComputePerPageValues(self, all_page_specific_values):
all_successful_page_values = [
- v for v in all_page_specific_values if not isinstance(
- v, failure.FailureValue)]
+ v for v in all_page_specific_values if not (isinstance(
+ v, failure.FailureValue) or isinstance(v, skip.SkipValue))]
# We will later need to determine how many values were originally created
# for each value name, to apply a workaround meant to clean up the printf
« no previous file with comments | « tools/telemetry/telemetry/value/skip_unittest.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698